Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-i18next-gen: init at 1.1.0 #267454

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ilyakooo0
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Luflosi
Copy link
Contributor

Luflosi commented Nov 14, 2023

Is it possible to package it using buildNpmPackage instead?
See #229475.

@ilyakooo0
Copy link
Contributor Author

Is what i did deprecated? Docs don't indicate that.

@Luflosi
Copy link
Contributor

Luflosi commented Nov 14, 2023

I wouldn't necessarily say deprecated, maybe more like discouraged. If I understand correctly, some packages can't (yet?) be packaged using buildNpmPackage and still need the old way but if packaging with buildNpmPackage works than that would be preferred.

@ilyakooo0
Copy link
Contributor Author

@Luflosi done

@ilyakooo0 ilyakooo0 force-pushed the iko/init-elm-i18next-gen branch from ef18a51 to 80515b1 Compare November 15, 2023 14:18
Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Compiles on x86_64-darwin.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 15, 2023
@dotlambda dotlambda changed the title elm-i18next-gen: init at 1.1.0 elmPackages.elm-i18next-gen: init at 1.1.0 Jan 9, 2024
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 26, 2024
@domenkozar domenkozar mentioned this pull request Sep 27, 2024
@turboMaCk
Copy link
Member

turboMaCk commented Oct 1, 2024

@ilyakooo0 Can you squash commit into one (keeping the message from original one) and resolve conflicts? Once this is done I can merge this.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants