-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elmPackages.elm-i18next-gen: init at 1.1.0 #267454
base: master
Are you sure you want to change the base?
Conversation
Is it possible to package it using |
Is what i did deprecated? Docs don't indicate that. |
I wouldn't necessarily say deprecated, maybe more like discouraged. If I understand correctly, some packages can't (yet?) be packaged using |
7d450f7
to
ef18a51
Compare
@Luflosi done |
ef18a51
to
80515b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Compiles on x86_64-darwin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit message.
Co-authored-by: Robert Schütz <[email protected]>
@ilyakooo0 Can you squash commit into one (keeping the message from original one) and resolve conflicts? Once this is done I can merge this. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)