bazel_6: fix CLang 16 Werror-s on darwin #269297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazel_6 https://hydra.nixos.org/build/241090720/nixlog/1 ``` external/upb/upb/upb.c:228:25: error: defining a type within '__builtin_offsetof' is a Clang extension [-Werror,-Wgnu-offsetof-extensions] n = UPB_ALIGN_DOWN(n, UPB_ALIGN_OF(upb_Arena)); ^~~~~~~~~~~~~~~~~~~~~~~ ``` bazel_6 https://hydra.nixos.org/build/241127779/nixlog/1 ``` In file included from external/com_google_absl/absl/algorithm/container.h:55: external/com_google_absl/absl/meta/type_traits.h:560:8: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins] (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) && ^ ``` Note: `bazel_5` and `bazel_4` require more work, for some reason extra `-Wall` in combination with `-Werror` sneaks in and overrides `-Wno-` settings, haven't managed yet to debug where exactly are the last flags (last one wins) come from there. ZHF: NixOS#265948
boltzmannrain
added
the
0.kind: ZHF Fixes
boltzmannrain
added a commit
to boltzmannrain/nixpkgs
that referenced
this pull request
Nov 23, 2023
Fixing `bazel_5` after NixOS#234710 Error example https://hydra.nixos.org/build/241240612/nixlog/1 ``` external/com_google_absl/absl/meta/type_traits.h:560:8: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins] (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) && ``` Similar to NixOS#269297, and remaining `bazel_4` is WIP for another PR
13 tasks
boltzmannrain
added a commit
to boltzmannrain/nixpkgs
that referenced
this pull request
Nov 23, 2023
Fixing `bazel_4` after NixOS#234710 Error example https://hydra.nixos.org/build/241174862/nixlog/1 ``` Execution platform: //:default_host_platform third_party/zlib/gzwrite.c:89:20: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] writ = write(state->fd, strm->next_in, put); ^ ``` Similar to NixOS#269481 and NixOS#269297
13 tasks
This was referenced Nov 28, 2023
|
Successfully created backport PR for |
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Fixing `bazel_5` after #234710 Error example https://hydra.nixos.org/build/241240612/nixlog/1 ``` external/com_google_absl/absl/meta/type_traits.h:560:8: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins] (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) && ``` Similar to #269297, and remaining `bazel_4` is WIP for another PR (cherry picked from commit 781538c)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Fixing `bazel_4` after #234710 Error example https://hydra.nixos.org/build/241174862/nixlog/1 ``` Execution platform: //:default_host_platform third_party/zlib/gzwrite.c:89:20: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] writ = write(state->fd, strm->next_in, put); ^ ``` Similar to #269481 and #269297 (cherry picked from commit 746e394)
|
[comment deleted] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixing
bazel_6after #234710bazel_6 https://hydra.nixos.org/build/241090720/nixlog/1
bazel_6 https://hydra.nixos.org/build/241127779/nixlog/1
Note:
bazel_5andbazel_4require more work, for some reason extra-Wallin combination with-Werrorsneaks in and overrides-Wno-settings, haven't managed yet to debug where exactly are the last flags (last one wins) come from there.ZHF: #265948
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.