python3Packages.simple-term-menu: init at 1.6.4 #274960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedmoizurrehman
force-pushed
the
add-simple-term-menu
branch
from
a6f4eaf to
b8dc22c
Compare
|
I have tested this change by importing my local nixpkgs and using the |
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
syedmoizurrehman
force-pushed
the
add-simple-term-menu
branch
from
b8dc22c to
7f448aa
Compare
syedmoizurrehman
requested review from
piegamesde and
Janik-Haag
as code owners
|
Result of 4 packages built:
|
natsukium
requested changes
Dec 28, 2023
kirillrdy
reviewed
Dec 28, 2023
syedmoizurrehman
force-pushed
the
add-simple-term-menu
branch
from
7f448aa to
50e01aa
Compare
|
@GrahamcOfBorg build python310Packages.simple-term-menu python311Packages.simple-term-menu |
kirillrdy
approved these changes
Dec 28, 2023
delroth
added
the
12.approvals: 1
natsukium
approved these changes
Dec 29, 2023
|
@natsukium Thank you, I appreciate you and @kirillrdy taking the time to review the changes! |
|
Feel free to ping us if you would like a PR review or have any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add Python package simple-term-menu.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.