Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: cleanup unnecessary generic function #281785

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

nevivurn
Copy link
Member

@nevivurn nevivurn commented Jan 18, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from peterhoeg and viric January 18, 2024 14:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 18, 2024
@nevivurn nevivurn force-pushed the feat/openvpn-cleanup branch 3 times, most recently from 082bf6b to 8eadfaa Compare January 25, 2024 12:21
@nevivurn nevivurn force-pushed the feat/openvpn-cleanup branch from 8eadfaa to f2be8e2 Compare January 25, 2024 12:22
@nevivurn
Copy link
Member Author

Sorry about the noise, I have addressed the review comments.

@ofborg ofborg bot requested a review from peterhoeg January 25, 2024 12:53
@infinisil
Copy link
Member

You can ignore the pkgs/by-name failure, the PR can be merged even if it's red without causing problems. The fix for this is already merged with #283017, though it'll take some time for it to be applied.

@peterhoeg peterhoeg merged commit df2f1a8 into NixOS:master Jan 29, 2024
23 of 25 checks passed
@nevivurn nevivurn deleted the feat/openvpn-cleanup branch January 29, 2024 15:02
@infinisil
Copy link
Member

Btw this kind of pkgs/by-name check failure is fixed for future PRs now that #284765 is merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants