-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv.darwin: bootstrap darwin using updated tools #301252
Conversation
aarch64-apple-darwinsha256sum of files to be uploaded:
Suggested commands to upload files to 'tarballs.nixos.org':
x86_64-apple-darwinsha256sum of files to be uploaded:
Suggested commands to upload files to 'tarballs.nixos.org':
|
- update the hashes and tools needed to extract the bootstrap-tools archive - unify the x64 and aarch64 unpack process
rebased with staging to get the fix #301310 for the format check workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built successfully on x86_64-darwin and aarch64-darwin. lgtm
ping @lovesegfault for tools update (thanks!): info here #301252 (comment) hopefully no xz backdoors in this round. |
Uhhh, what? The contributor who got us to include the vulnerable I have not uploaded the bootstrap tarballs here. I think perhaps we should revoke the vulnerable ones entirely? Even though AFAIK the xz malware does not do anything when running on Darwin. |
This was |
Let's be careful with any implications or accusations. |
Description of changes
update the hashes and tools needed to extract the bootstrap-tools archive
unify the x64 and aarch64 unpack process
second try of stdenv.darwin: bootstrap darwin using updated tools #295558 but after xz downgrade to 5.4.2
considered downgrading xz further for tools to 5.2.5 so not have to update again as 5.4.2 has commits from malicious committer but stuck with xz version in nixpkgs
considered using zstd / gzip for compression of tarball / unpack.nar but nix doesn't support gz for nar files
tools from:
testing:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.