-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssm-session-manager-plugin: migrate to buildGoModule #318850
ssm-session-manager-plugin: migrate to buildGoModule #318850
Conversation
73d037a
to
35bab6a
Compare
35bab6a
to
d2f65e2
Compare
d2f65e2
to
dd03ac7
Compare
Result of 3 packages built:
|
Please perform the move to by-name in a separate commit so Git can detect the rename and e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also above comment about rename commit. I wasn’t able to fully review changes as the diff is hard to process as a result.
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
dd03ac7
to
bbb4986
Compare
Description of changes
Migrating to
buildGoModule
sobuildGoPackage
can be deprecated as per #318069.Also moved to
by-name
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.