Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook-alerts: init at 0.6.0 #329812

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

brianmcgillion
Copy link
Contributor

Description of changes

Add mdbook-alerts a pre-processor for mdbook to support the inclusion of Markdown alerts.

https://github.com/lambdalisue/rs-mdbook-alerts

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@brianmcgillion
Copy link
Contributor Author

The result of nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"

$nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/brian/.cache/nixpkgs-review/rev-9d5f0e521ee51394548b3aebfa9c93df058a4a62/nixpkgs nixpkgs-overlays=/tmp/tmp6uzbw0m1 -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
1 package added:
mdbook-alerts (init at 0.6.0)

$ nix build --file /nix/store/fg7dh6aandk5iy5hmfr5n6n8nqggsr93-nixpkgs-review-2.10.5/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/brian/.cache/nixpkgs-review/rev-9d5f0e521ee51394548b3aebfa9c93df058a4a62/nixpkgs nixpkgs-overlays=/tmp/tmp6uzbw0m1' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/brian/.cache/nixpkgs-review/rev-9d5f0e521ee51394548b3aebfa9c93df058a4a62/nixpkgs --argstr nixpkgs-config-path /tmp/tmp47zsli_7.nix --argstr attrs-path /home/brian/.cache/nixpkgs-review/rev-9d5f0e521ee51394548b3aebfa9c93df058a4a62/attrs.nix
1 package built:
mdbook-alerts

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 25, 2024
@ofborg ofborg bot requested a review from matthiasbeyer July 25, 2024 04:48
Add mdbook-alerts a pre-processor for mdbook to support the inclusion of
Markdown alerts.

https://github.com/lambdalisue/rs-mdbook-alerts

Signed-off-by: Brian McGillion <[email protected]>
@brianmcgillion
Copy link
Contributor Author

Thank you @eclairevoyant for the quick review. Hopefully correct now. nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" is still passing after the change.

@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 329812 run on x86_64-linux 1

1 package built:
  • mdbook-alerts

@matthiasbeyer matthiasbeyer dismissed eclairevoyant’s stale review July 25, 2024 07:18

All remarks resolved IMO

@matthiasbeyer matthiasbeyer merged commit c1fd3ba into NixOS:master Jul 25, 2024
24 of 26 checks passed
@brianmcgillion brianmcgillion deleted the mdbook-alerts branch July 26, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants