display3d: init at 0.2.1

[renpenguin]

Added display3d, a CLI for rendering and animating 3D objects: https://github.com/renpenguin/display3d
Added renpenguin as a package maintainer for display3d

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[steeleduncan]

Also, all changes should be squashed so that there are only 2 commits. The first with the maintainers list change, the second adding the package

[steeleduncan]

It looks good to me, but I don't have commit access, and don't maintain a similar package, so it doesn't make sense for me to leave an approving review.

My suggestion to get it merged would be to find someone who has merged a PR comparable to this into nixpkgs recently, and ping them for a review

[renpenguin]

Hi @getchoo, are you able to review this? Thank you.

[Tert0]

I have successfully build and tested the package on x86_64-linux.

Suggestion:

diff --git a/pkgs/by-name/di/display3d/package.nix b/pkgs/by-name/di/display3d/package.nix
index 0d21771f5a86..c1e72086deaf 100644
--- a/pkgs/by-name/di/display3d/package.nix
+++ b/pkgs/by-name/di/display3d/package.nix
@@ -2,6 +2,8 @@
   lib,
   rustPlatform,
   fetchFromGitHub,
+  versionCheckHook,
+  nix-update-script,
 }:
 
 rustPlatform.buildRustPackage rec {
@@ -18,6 +20,12 @@ rustPlatform.buildRustPackage rec {
   useFetchCargoVendor = true;
   cargoHash = "sha256-E4Ncg9OPlYGra794pPS9u9oyqep+k3Ser5ZxfV+uSRM=";
 
+  nativeInstallCheckInputs = [ versionCheckHook ];
+  doInstallCheck = true;
+  versionCheckProgramArg = "--version";
+
+  passthru.updateScript = nix-update-script { };
+
   meta = {
     description = "CLI for rendering and animating 3D objects";
     homepage = "https://github.com/renpenguin/display3d";

[renpenguin]

I have successfully build and tested the package on x86_64-linux.

Suggestion:

diff --git a/pkgs/by-name/di/display3d/package.nix b/pkgs/by-name/di/display3d/package.nix
index 0d21771f5a86..c1e72086deaf 100644
--- a/pkgs/by-name/di/display3d/package.nix
+++ b/pkgs/by-name/di/display3d/package.nix
@@ -2,6 +2,8 @@
   lib,
   rustPlatform,
   fetchFromGitHub,
+  versionCheckHook,
+  nix-update-script,
 }:
 
 rustPlatform.buildRustPackage rec {
@@ -18,6 +20,12 @@ rustPlatform.buildRustPackage rec {
   useFetchCargoVendor = true;
   cargoHash = "sha256-E4Ncg9OPlYGra794pPS9u9oyqep+k3Ser5ZxfV+uSRM=";
 
+  nativeInstallCheckInputs = [ versionCheckHook ];
+  doInstallCheck = true;
+  versionCheckProgramArg = "--version";
+
+  passthru.updateScript = nix-update-script { };
+
   meta = {
     description = "CLI for rendering and animating 3D objects";
     homepage = "https://github.com/renpenguin/display3d";

done! should be ready for merge now

[Tert0]

LGTM

[getchoo]

Tested on x86_64-linux, and it seems all works well!

Thanks and welcome to Nixpkgs :)