python312Packages.tree-sitter: enable tests #377525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gepbird
force-pushed
the
py-tree-sitter-fix-build
branch
3 times, most recently
from
9dd11d2 to
ee4c09e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
GaetanLepage
approved these changes
Jan 28, 2025
This comment was marked as outdated.
This comment was marked as outdated.
GaetanLepage
approved these changes
Jan 29, 2025
wegank
added
12.approvals: 1
gepbird
force-pushed
the
py-tree-sitter-fix-build
branch
3 times, most recently
from
00d61f5 to
36fc8b9
Compare
gepbird
changed the title
|
@GaetanLepage Fixed merge conflicts. We tried to debug this issue with upstream who provided a patch. In the meantime tests were disabled for python tree-sitter to fix the same issue, I think the patch can be a little safer, just in case dependant packages get a random segfault, but so far this didn't happen. @K900 I see you were confused with how python tree-sitter only fails on aarch64 in 3f33d0eedccca, in short this is what we know so far about this bug:
Upstream issue: tree-sitter/py-tree-sitter#330 (comment) |
|
python tree-sitter builds, but some dependencies of private-gpt are failing
|
gepbird
force-pushed
the
py-tree-sitter-fix-build
branch
from
36fc8b9 to
06cbc04
Compare
gepbird
changed the title
wegank
removed
the
12.approvals: 1
gepbird
force-pushed
the
py-tree-sitter-fix-build
branch
from
06cbc04 to
c31e83e
Compare
|
GaetanLepage
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372375
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.