-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdk_pixbuf: 2.36.7 → 2.36.12 #39026
Merged
Merged
gdk_pixbuf: 2.36.7 → 2.36.12 #39026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60caba4
to
be4ca96
Compare
Still need to move installed tests to a separate output. |
Success on aarch64-linux (full log) Attempted: gdk_pixbuf Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: gdk_pixbuf Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gdk_pixbuf Partial log (click to expand)
|
jtojnar
added a commit
that referenced
this pull request
Apr 21, 2018
Merged again in 4b2f397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previous attempt failed due to
gdk-pixbuf
forcing the use ofshared-mime-info
, which did not work on systems that missed it in theirXDG_DATA_DIRS
. Since there is no way to propagates-m-i
fromgdk-pixbuf
toXDG_DATA_DIRS
of all the depending packages, we are patching the build script not to enable type sniffing. Proper solution would be hardcoding thes-m-i
path into glib.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)