openssl: don't autodetect platform on armv6/7l #47953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
OpenSSL currently generates invalid armv6l instructions when compiled on an armv7l machine because it uses its own system for detecting the architecture, so the autotools
build_alias
trick does not work. This type of build seems to be a little controversial and unsupported in nixpkgs, but I think this PR is harmless and makes the build more pure.Things done
This PR explicitly specifies the architecture on armv6l and armv7l, causing the correct instructions to be generated even when building for armv6l on armv7l. This change does not affect other architectures.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)