-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qutebrowser: downgrade Qt to 5.14 #99456
Conversation
There are a number of unresolved issues with Qt 5.15, the most important one being the inability to properly restore sessions[1]. For now it's better to stay at the earlier version. [1]: qutebrowser/qutebrowser#5359
Backport: 3bef864 |
FWIW other than the session support, I think all of those issues are either fixed in Qt 5.15.1 (or .2), or just not relevant outside of qutebrowser development. The only other remaining issue with Qt 5.15.1 are renderer process crashes which can be fixed by backporting this patch: [Backport] Fix for bug 1071327 (Icf418990) · Gerrit Code Review As for the session support, the choice is between being able to fully restore sessions or having security patches:
IMHO, for a web browser, lagging behind more than absolutely necessary with security patches is a bigger problem than not getting back-/forward history after restoring sessions. |
Hi, thank you for chiming in. I didn't most of the issue were already resolved, I'll take a look at the patch and consider porting it. |
For security reasons [1] we upgrade to the latest Qt, despite this breaking a feature, which is why 5.14 was forced earlier. [1] NixOS#99456 (comment)
I'm working on a PR to add that patch to our qt5.15 |
qtwebengine PR: #100041 |
For security reasons [1] we upgrade to the latest Qt, despite this breaking a feature, which is why 5.14 was forced earlier. [1] NixOS#99456 (comment) (cherry picked from commit 902c567)
Motivation for this change
There are a number of unresolved issues with Qt 5.15, the most
important one being the inability to properly restore sessions1.
For now it's better to stay at the earlier version.
Things done
./result/bin/
)nix path-info -S
before and after)