Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can modify redis timeout mid stream #124

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

michaelglass
Copy link
Contributor

@michaelglass michaelglass commented Nov 27, 2024

adds the ability to modify query timeout on a handler

@michaelglass michaelglass force-pushed the can-modify-redis-timeout-mid-stream branch from 78f4b52 to 49c3dee Compare November 27, 2024 22:04
@michaelglass michaelglass marked this pull request as ready for review November 27, 2024 22:05
@@ -1,4 +1,10 @@
# 0.2.0.3 unreleased

- [bugfix] When a query times out, its context is no longer removed from the Stack
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is in #123

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having such flexibility makes sense. But I worry it could end up being hard to track in application code.

@michaelglass michaelglass added this pull request to the merge queue Nov 27, 2024
Merged via the queue into trunk with commit 25b0516 Nov 27, 2024
1 of 2 checks passed
@michaelglass michaelglass deleted the can-modify-redis-timeout-mid-stream branch November 28, 2024 08:10
@michaelglass
Copy link
Contributor Author

yeah I think ... maybe this should have a tracing span

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants