Add Notification Permission Feature #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philips77
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
The PR looks very good.
My only question is regarding a purpose of it. Why do you REQUIRE notifications? Users should be able to deny them and app should work just fine. Even foreground service can be started with a notification, which will be hidden by the system, but the service will work just fine.
In my opinion the lib should allow easy way for requesting it if they are not granted, but it should be some method called as Lunch effect, or from a View Model. Your current solution suggests that notifications are required to show some UI, and I don't see any situation where it would be true.
| get() = context.getSharedPreferences(SHARED_PREFS_NAME, Context.MODE_PRIVATE) | ||
|
|
||
| val isTiramisuOrAbove: Boolean | ||
| @ChecksSdkIntAtLeast(api = Build.VERSION_CODES.TIRAMISU) |
philips77
force-pushed
the
permission-notification
branch
from
eb0de9d to
98266a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to handle notification permissions in the app. Specifically, it adds logic to request and check the status of notification permissions for Android devices running Android 13 (API level 33) and above.