Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the msbuild binlog path when invoking static graph restore to avoid modifying the environment #10789

Closed
ViktorHofer opened this issue Apr 21, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#6116
Assignees
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. SeQuality Type:DCR Design Change Request
Milestone

Comments

@ViktorHofer
Copy link

Details about Problem

NuGet product used (NuGet.exe | Visual Studio | MSBuild.exe | dotnet.exe): dotnet.exe

Product version: 6.0.100-preview.3.21202.5

Worked before? If so, with which NuGet version:

Repro steps and/or sample project

When using static graph restore, the environment variable RESTORE_TASK_BINLOG_PARAMETERS needs to be set to generate a binlog for the out-of-process evaluation of the projects. If you are already inside an msbuild instance, it's not possible to modify the existing environment variables without a custom task (either compiled or inline).

To avoid modifying the existing environment, RestoreTaskEx task could accept a property to specify the path to the restore binlog which is then passed in as an environment variable to the restore task console.

Verbose Logs

@nkolev92 nkolev92 added Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug Area:RestoreStaticGraph Issues related to the Static Graph restore labels Apr 27, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-04 milestone Apr 27, 2021
@nkolev92 nkolev92 added the Community PRs (and linked Issues) created by someone not in the NuGet team label May 3, 2021
@nkolev92 nkolev92 removed the Community PRs (and linked Issues) created by someone not in the NuGet team label Aug 30, 2021
@nkolev92 nkolev92 added Community PRs (and linked Issues) created by someone not in the NuGet team and removed Community PRs (and linked Issues) created by someone not in the NuGet team labels Nov 2, 2021
@nkolev92 nkolev92 removed this from the Sprint 2021-11 milestone Nov 2, 2021
@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:2 Issues for the current backlog. labels Nov 2, 2021
@jeffkl jeffkl added Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Oct 23, 2024
@jeffkl jeffkl self-assigned this Oct 23, 2024
@jeffkl jeffkl added Type:DCR Design Change Request and removed Type:Bug labels Oct 24, 2024
@Nigusu-Allehu Nigusu-Allehu added this to the 6.13 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. SeQuality Type:DCR Design Change Request
Projects
None yet
7 participants