Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify MSBuild binary logger parameters for static graph-based restore #6116

Merged

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Oct 23, 2024

Bug

Fixes: NuGet/Home#10789
Fixes: NuGet/Home#13876

Description

This pull requests allows users to specify MSBuild properties to enable the MSBuild binary logger for project evaluations and builds when using static graph-based restore.

Property Name Description Default
RestoreStaticGraphEnableBinaryLogger Enables the MSBuild binary logger for project evaluations and builds. (null)
RestoreStaticGraphBinaryLoggerParameters Specifie the parameters for the MSBuild binary logger. LogFile=nuget.binlog if RestoreStaticGraphEnableBinaryLogger is true

If the user specifies any value for the RESTORE_TASK_BINLOG_PARAMETERS environment variable, the binary logger is enabled with those parameters.

This also stops automatically adding the binary logger when debugging to fix NuGet/Home#13876

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jeffkl jeffkl self-assigned this Oct 23, 2024
@jeffkl jeffkl requested a review from a team as a code owner October 23, 2024 20:57
@jeffkl
Copy link
Contributor Author

jeffkl commented Oct 23, 2024

This supersedes #4010

@jeffkl jeffkl merged commit 27615d6 into dev Oct 28, 2024
30 of 32 checks passed
@jeffkl jeffkl deleted the dev-jeffkl-static-graph-restore-binary-logger-parameters branch October 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants