Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read PackageReferences from CollectPackageReferences #4967

Closed
emgarten opened this issue Apr 4, 2017 · 4 comments
Closed

Read PackageReferences from CollectPackageReferences #4967

emgarten opened this issue Apr 4, 2017 · 4 comments
Assignees
@emgarten
Labels
Functionality:Restore
Milestone
4.4

Comments

@emgarten
Copy link
Member

emgarten commented Apr 4, 2017

Restore should read PackageReferences from CollectPackageReferences instead of the items directly.

see: dotnet/project-system#653
@emgarten
Copy link
Member Author

emgarten commented Apr 4, 2017

As part of this work we will need to ensure that PackageReferences coming from targets/props in packages are ignored. This would cause the first restore to give a different result than the 2nd and 3rd restores.

@emgarten emgarten mentioned this issue Apr 4, 2017
Closed
@emgarten emgarten self-assigned this Aug 3, 2017
@emgarten emgarten added this to the 4.4 milestone Aug 3, 2017
@emgarten
Copy link
Member Author

emgarten commented Aug 3, 2017

https://github.com/dotnet/project-system/blob/708af7ef0b285f85fcc624e0b5c1a8ab193ea573/src/Targets/Microsoft.Managed.DesignTime.targets#L272

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 4, 2017
@emgarten
Read PackageReferences from CollectPackageReferences
13bbbeb 
This adds an extension point for MSBuild targets to hook into restore with AfterTargets and BeforeTargets. CollectPackageReferences is called in Visual Studio, NuGet.exe, dotnet restore, and MSBuild restore.

Fixes NuGet/Home#4967
This was referenced Aug 4, 2017
Merged
Closed
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 30, 2017
@emgarten
Read PackageReferences from CollectPackageReferences
bb61057 
This adds an extension point for MSBuild targets to hook into restore with AfterTargets and BeforeTargets. CollectPackageReferences is called in Visual Studio, NuGet.exe, dotnet restore, and MSBuild restore.

Fixes NuGet/Home#4967
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 31, 2017
@emgarten
Read PackageReferences from CollectPackageReferences
2cd87f6 
This adds an extension point for MSBuild targets to hook into restore with AfterTargets and BeforeTargets. CollectPackageReferences is called in Visual Studio, NuGet.exe, dotnet restore, and MSBuild restore.

Fixes NuGet/Home#4967
@davkean
Copy link

davkean commented Sep 4, 2017

@emgarten What release will this be in - so that we can remove our version?

@emgarten
Copy link
Member Author

emgarten commented Sep 5, 2017

@davkean VS 15.4, NuGet 4.4.0

@cartermp cartermp mentioned this issue Sep 21, 2017
Closed
@binki binki mentioned this issue Sep 10, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Functionality:Restore
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@davkean @emgarten