Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Failures in package signing code when executed on .NET 5 master #9509

Closed
kartheekp-ms opened this issue May 4, 2020 · 2 comments
Closed

Test Failures in package signing code when executed on .NET 5 master #9509

kartheekp-ms opened this issue May 4, 2020 · 2 comments
Assignees
@kartheekp-ms
Labels
Functionality:Signing Type:Test

Comments

@kartheekp-ms
Copy link
Contributor

kartheekp-ms commented May 4, 2020 •
edited
Loading

Package signing branch has few new entries defined in build/config.props to define dotnet cli version for building and running tests. Updated CliVersionForBuilding .NET SDK version to .NET 5 latest stable preview release and CliVersionForTesting to master to test using latest release.

Link to CI Build for the PR

  • Windows (IsCore)
    • PackCommand_PackSolution_AddsProjectRefsAsPackageRefs
    • PackCommand_PackLicense_IncludeLicenseFileWithSnupkg
    • PackCommand_PackLicense_IncludeLicenseFileWithSymbolsNupkg
    • PackCommand_PackProject_AddsProjectRefsAsPackageRefs
    • PackCommand_PackNewDefaultProject_IncludeBuildOutputDoesNotCreateLibFolder
    • PackCommand_PackNewDefaultProject_InstallPackageToOutputPath
    • PackCommand_PackProjectWithPackageType_SnupkgContainsOnlyOnePackageType
    • PackCommand_PackNewDefaultProject_IncludeSymbolsWithSnupkg
    • PackCommand_PackNewDefaultProject_NupkgExists
    • PackCommand_PackNewDefaultProject_BuildOutputTargetFolderOutputsLibsToRightFolder
    • PackCommand_PackEmbedInteropPackage
@kartheekp-ms kartheekp-ms mentioned this issue May 4, 2020
Merged
@kartheekp-ms kartheekp-ms added this to the Sprint 170 - 2020.05.04 milestone May 4, 2020
@kartheekp-ms kartheekp-ms self-assigned this May 4, 2020
@kartheekp-ms
Copy link
Contributor Author

All the tests are failed due to TFM errors. I believe @zivkan work will fix these test failures.

@kartheekp-ms
Copy link
Contributor Author

All these tests are now passing in the official build pipeline. Hence closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartheekp-ms kartheekp-ms

Labels
Functionality:Signing Type:Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkolev92 @heng-liu @kartheekp-ms