Updated SDK version and removed the hardcoded version when reading from JSON file #3372

kartheekp-ms · 2020-04-30T01:32:49Z

Bug

Fix

Details : Package signing branch has few new entries defined in build/config.props to define dotnet cli version for building and running tests. Updated CliVersionForBuilding .NET SDK version to .NET 5 latest stable preview release and CliVersionForTesting to master to test using latest release.

Removed the hardcoded NuGet Build Tasks version in Integration tests code

NuGet.Client/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuildIntegrationTestFixture.cs

Line 488 in 56b5bc2

string nugetBuildTasksName = "NuGet.Build.Tasks/5.3.0-rtm.6251";

Testing/Validation

Tests Added: Yes
Validation:

src/NuGet.Core/NuGet.Protocol/Converters/JsonExtensions.cs

…ded version

zivkan · 2020-04-30T18:32:47Z

are you going to run a CI build?

kartheekp-ms · 2020-04-30T19:42:17Z

are you going to run a CI build?

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3692054&view=results

heng-liu · 2020-05-01T04:42:08Z

LGTM. Just one question, is it possible to specify a partial version in global.json?
Could you pls raise issues for the newly brought in issues? Thanks.
e.g. ExecuteCommandAsync_WithEmptyPkcs7File_ThrowsAsync and several pack tests.

heng-liu · 2020-05-01T05:42:27Z

@zkat Shall we rebase from dev to make the Apex and E2E could run? Not sure if new SDK would bring in any issues in Apex and E2E.

kartheekp-ms · 2020-05-03T23:58:14Z

LGTM. Just one question, is it possible to specify a partial version in global.json?

Yes, it is possible as per doc.The following example shows how to use the highest version installed that is greater or equal than the version specified in global.json file.

{
  "sdk": {
    "version": "3.1.100",
    "allowPrerelease": true,
    "rollForward": "latestMajor"
  }
}

I have .NET Core SDK 3.* and 5.* installed on my machine. dotnet --version command when executed under the directory with above content in global.json file has produced following result.
5.0.100-preview.3.20216.6.

kartheekp-ms · 2020-05-04T14:55:43Z

Could you pls raise issues for the newly brought in issues? Thanks.
e.g. ExecuteCommandAsync_WithEmptyPkcs7File_ThrowsAsync and several pack tests.

Created an issue to track test failures in the CI build and that were not flaky. For e.g. VerifyCommand_WithAuthorSignedPackage_FailsGracefully test case on Mac failed in this build and also in the next build. Hence this test case was not included in the new issue.

…om JSON file (#3372)

* Signing: Support signature verification on .NET Core Remove 2nd N.B.T.P package (#2984) remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable (#3161) * remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable version, fix error; change LockSDKVersion default value from empty string to false; apply Linux workaround in my change Retarget to netcore5.0 (#3162) * retarget to netcore5.0; Linux script workaround need to apply for downloading SDK for build add pkcs and cng packages Temporary fix on patching SDK, add System.Security.Cryptography.Pkcs.dll and update deps.json, use dll from .nuget/packages Address PR comments implement add cert to store on Mac; display openssl version (#3166) Implement timestamp integrity verification; Implement an equivalent NativeCms; enable signing APIs and tests (#3168) * implement timestamp integrity verification; implement ManagedCms; enable signing APIs and tests fix xplat verification branch after rebase (#3191) Fixes: NuGet/Home#9012 check different cross-platform error messages for self-signed cert test (#3208) Fixes: NuGet/Home#8933 Xplat Signing/Verification : Fix broken tests for setting privatekey of a X509Certificate2 (#3195) use workaround to set private key for X509Certificate2 (netcore), change ToRSA to workaround for netcore(especially for non-windows) enable PathTooLongException test (#3216) Fixes: NuGet/Home#8920 enable TrustedSignerActionsProvider on netcore, along with tests (#3213) Fixes: NuGet/Home#8921 Enable SignedPackageIntegrityVerificationTests for netcore5.0 (#3220) Enable SignedPackageIntegrityVerificationTests for netcore, remove extra preprocessors Enable timestamp provider test and fix 3 broken tests (#3210) enable all unit tests; enable 8 more tests; enable timestampProviderTest; fix 3 broken tests in TimestampProviderTests Fix 4 tests in SignatureTrustAndValidityVerificationProviderTests (#3242) fix untrusted msg for different platforms fixed broken tests using utility methods (#3263) disable outdated tests (#3274) enable 4 tests on Mac (#3275) fix 5 broken tests in SignatureTrustAndValidityVerificationProviderTests, add workaround for Linux (#3252) fix broken test case ExecuteCommandAsync_WithAmbiguousMatch_ThrowsAsync (#3291) * Enable test ExecuteCommandAsync_WithMultiplePackagesAndInvalidCertificate_RaisesErrorsOnceAsync (#3342) * enable a test, change the comments; extend test limitation on Linux * Updated SDK version and removed the hardcoded version when reading from JSON file (#3372) * update Pkcs package to the preview3 version (#3382) * fix 2 warnings in CodeAnalysis (#3388) * fix 2 warnings in CodeAnalysis * disable dynamic revoke tests on Mac (#3373) * fix 1 test (#3371) * Fix more warnings reported by CodeAnalysis (#3393) * fix string warnings raised by CodeAnalysis * Retarget xplat verification to netcoreapp5.0 (#3386) * retarget netcoreapp5.0 (a workaround for net5.0) * fix all the rest warnings raised by code analysis (#3401) * Suppress CA1307 warning for string.GetHashCode() method (#3404) * Linux test failure due to generic exception (#3405) * add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects (#3419) * add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects * add PIN prompt for netcore (#3389) * Run dotnet nuget tests on multiple TFMs (#3387) * enabled mac assertions * Revert "enabled mac assertions" This reverts commit d8a52e2. * Enable test GetCertificateChain_WithUntrustedRoot_Throws on Mac (#3428) * run signing integration tests cross plat (#3415) * added GetNonce() to IRfc3161TimestampRequest interface (#3427) * disable test for netcore (#3445) * log Status and StatusInformation, fix 2 tests (#3268) * Disable verification during extraction for Mono, disable a test on Mono (#3451) * disable verification during extraction on mono,disable a mono test on Mac * adapt 2 newly added dotnet integration tests for multiple TFMs (#3460) * remove useless Sdk2x.targets * get TimestampTests working again (#3218) * get TimestampTests working again Fixes: NuGet/Home#8935 * change GetTimestampAsync into internal * fix runFuncTests.sh and InstallCLIforBuild.sh * address feedback * upgrade dotnet 5 to preview4 as preview5 is broken * Fix exception thrown in SigningTestFixture during disposing (#3464) Co-authored-by: Kartheek Penagamuri <[email protected]> Co-authored-by: Andy Zivkovic <[email protected]> Co-authored-by: Kat Marchán <[email protected]>

kartheekp-ms added 9 commits April 22, 2020 13:38

changed sdk versions for building and testing

beb0463

remove hardcoded nuget build task version

cd9905a

fixed compile time error

13ddc60

work around to remove the hard-coded build tasks version

929714c

fixed xml comment

49d87ad

Used JObject API to search properties

e69443b

renamed JObject extension method to resemble newtonsoft json api

94f7027

updated .net core sdk to 5.0.100-preview.3.20216.6

24da5eb

added units for json utility and null check

a8c9e5b

kartheekp-ms requested review from aortiz-msft, cristinamanum, dominoFire, donnie-msft, dtivel, heng-liu, nkolev92, rrelyea, zivkan and zkat as code owners April 30, 2020 01:32

nkolev92 reviewed Apr 30, 2020

View reviewed changes

src/NuGet.Core/NuGet.Protocol/Converters/JsonExtensions.cs Outdated Show resolved Hide resolved

kartheekp-ms added 2 commits April 29, 2020 19:52

reverted public method and added the code inline to remove the hardco…

25f3675

…ded version

reverted to previous commit (removed msbulddeps string)

a8694c8

zivkan approved these changes Apr 30, 2020

View reviewed changes

kartheekp-ms changed the title ~~Updated SDK version and added utility method to remove the hardcoded version~~ Updated SDK version and removed the hardcoded version when reading from JSON file Apr 30, 2020

kartheekp-ms force-pushed the dev-kartheekp-ms-xplat-buildsdkversion-9029 branch from a8694c8 to cd9905a Compare May 1, 2020 22:28

heng-liu approved these changes May 1, 2020

View reviewed changes

kartheekp-ms mentioned this pull request May 4, 2020

Test Failures in package signing code when executed on .NET 5 master NuGet/Home#9509

Closed

kartheekp-ms merged commit 0bc5fb5 into dev-feature-xplatVerification May 4, 2020

kartheekp-ms deleted the dev-kartheekp-ms-xplat-buildsdkversion-9029 branch May 4, 2020 19:34

kartheekp-ms mentioned this pull request May 4, 2020

Linux Test Failures in package signing code when executed on .NET 5 master NuGet/Home#9523

Closed

heng-liu pushed a commit that referenced this pull request May 7, 2020

Updated SDK version and removed the hardcoded version when reading fr…

6aae258

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request May 20, 2020

Updated SDK version and removed the hardcoded version when reading fr…

716b4ee

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request May 26, 2020

Updated SDK version and removed the hardcoded version when reading fr…

9b1fe34

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request Jun 12, 2020

Updated SDK version and removed the hardcoded version when reading fr…

8c69016

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request Jun 16, 2020

Updated SDK version and removed the hardcoded version when reading fr…

5460111

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request Jun 17, 2020

Updated SDK version and removed the hardcoded version when reading fr…

a5aec0f

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request Jun 19, 2020

Updated SDK version and removed the hardcoded version when reading fr…

2250414

…om JSON file (#3372)

heng-liu pushed a commit that referenced this pull request Jun 19, 2020

Updated SDK version and removed the hardcoded version when reading fr…

2d8566f

…om JSON file (#3372)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated SDK version and removed the hardcoded version when reading from JSON file #3372

Updated SDK version and removed the hardcoded version when reading from JSON file #3372

kartheekp-ms commented Apr 30, 2020 •

edited

Loading

zivkan commented Apr 30, 2020

kartheekp-ms commented Apr 30, 2020

heng-liu commented May 1, 2020

heng-liu commented May 1, 2020

kartheekp-ms commented May 3, 2020 •

edited

Loading

kartheekp-ms commented May 4, 2020 •

edited

Loading

Updated SDK version and removed the hardcoded version when reading from JSON file #3372

Updated SDK version and removed the hardcoded version when reading from JSON file #3372

Conversation

kartheekp-ms commented Apr 30, 2020 • edited Loading

Bug

Fix

Testing/Validation

zivkan commented Apr 30, 2020

kartheekp-ms commented Apr 30, 2020

heng-liu commented May 1, 2020

heng-liu commented May 1, 2020

kartheekp-ms commented May 3, 2020 • edited Loading

kartheekp-ms commented May 4, 2020 • edited Loading

kartheekp-ms commented Apr 30, 2020 •

edited

Loading

kartheekp-ms commented May 3, 2020 •

edited

Loading

kartheekp-ms commented May 4, 2020 •

edited

Loading