Write static graph restore arguments to standard input instead of passing on the command-line #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
reviewed
Aug 30, 2022
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-static-graph-restore-argument-file
branch
from
795db93 to
c4f4957
Compare
zivkan
previously approved these changes
Sep 5, 2022
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
zivkan
previously approved these changes
Sep 7, 2022
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
jeffkl
removed
the
Status:No recent activity
nkolev92
previously approved these changes
Sep 14, 2022
src/NuGet.Core/NuGet.Build.Tasks/GetReferenceNearestTargetFrameworkTask.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
nkolev92
previously approved these changes
Sep 15, 2022
|
@nkolev92 what are your thoughts about when to merge this? Do you feel its too risky for 17.4? |
|
We can wait for 17.5. |
jeffkl
added
the
Merge next release
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
erdembayar
reviewed
Sep 23, 2022
src/NuGet.Core/NuGet.Build.Tasks/StaticGraphRestoreArguments.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
Status:No recent activity
jeffkl
force-pushed
the
dev-jeffkl-static-graph-restore-argument-file
branch
2 times, most recently
from
df09dd6 to
aecb3f2
Compare
zivkan
reviewed
Oct 10, 2022
test/NuGet.Core.Tests/NuGet.Build.Tasks.Test/StaticGraphRestoreArgumentsTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-static-graph-restore-argument-file
branch
from
90fa662 to
0e2267d
Compare
jeffkl
force-pushed
the
dev-jeffkl-static-graph-restore-argument-file
branch
from
0e2267d to
5a087f7
Compare
jeffkl
force-pushed
the
dev-jeffkl-static-graph-restore-argument-file
branch
from
5a087f7 to
03f3cf8
Compare
zivkan
approved these changes
Oct 11, 2022
jeffkl
removed
the
Merge next release
|
@nkolev92 are you okay if I merge this? |
|
Yep, I had reviewed it in the past, and it looks like it was mostly cleanup that was added on top. |
jeffkl
added a commit
that referenced
this pull request
Mar 9, 2023
…ts to standard input (#5080) * Revert "Properly handle alternate console stream encodings in StaticGraphRestoreArguments (#5010)" This reverts commit 6512bed. * Revert "Write static graph restore arguments to standard input instead of passing on the command-line (#4772)" This reverts commit 19a4170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11968
Regression? Last working version:
Description
Write the arguments to standard input and read them in the new process. Also refactored
GenerateRestoreGraphFileTaskto use a base class thatRestoreTaskExalso uses since so much of the logic was duplicated.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation