Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] document_type_id move required attribute from object to view #1062

Merged

Conversation

renatonlima
Copy link
Member

Movido o atributo requerido do campo document_type_id do objeto para a visão para não impactar a criação de faturas (account.invoice) sem um documento fiscal (apenas relacionada com o l10n_br_fiscal.fiscal_document_dummy).

@rvalyi
Copy link
Member

rvalyi commented Jan 4, 2021

(o erro do Travis novamente é do teste do payment_cielo da KMEE e nao tem a ver com o PR)

@rvalyi
Copy link
Member

rvalyi commented Jan 4, 2021

é legal ser aprovado, mas nao sei se é legal fazer merge com o problema no teste da gateway cielo. Na vdd o teste sempre falharia a gente fazendo o merge ou nao, so nao seria legal passar a mensagem que a gente nao liga para a CI estar OK no projeto...

@renatonlima
Copy link
Member Author

@gabrielcardoso21 Você consegue ver esse erro https://travis-ci.com/github/OCA/l10n-brazil/jobs/468217433#L2954 no teste do modulo payment_cielo? Porque seria bom fazer os merges com o travis verde...

@gabrielcardoso21
Copy link
Contributor

O @DiegoParadeda fez um PR de correção do travis: #1064

@renatonlima renatonlima force-pushed the 12.0-fiscal-document-type-not-required branch from ace164f to 3e8215e Compare January 6, 2021 20:44
@renatonlima renatonlima force-pushed the 12.0 branch 2 times, most recently from 88fcd7b to bfe4567 Compare January 6, 2021 22:31
@renatonlima renatonlima force-pushed the 12.0-fiscal-document-type-not-required branch from 3e8215e to 71df066 Compare January 7, 2021 11:49
@renatonlima renatonlima force-pushed the 12.0 branch 2 times, most recently from 7b2f6a6 to 6100848 Compare January 8, 2021 14:30
@renatonlima renatonlima force-pushed the 12.0-fiscal-document-type-not-required branch from 71df066 to e65f344 Compare January 8, 2021 14:44
@renatonlima renatonlima force-pushed the 12.0-fiscal-document-type-not-required branch from e65f344 to b7b15fd Compare January 8, 2021 21:26
@rvalyi
Copy link
Member

rvalyi commented Jan 9, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1062-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 89ae891 into OCA:12.0 Jan 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb3df06. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants