Fix linting

ebill_paynet/models/paynet_invoice_message.py

@@ -129,19 +129,24 @@ def _get_payload_params(self):
         # Get the invoice due date
         date_due = None
         if self.invoice_id.invoice_payment_term_id:
-            terms = self.invoice_id.invoice_payment_term_id.compute(self.invoice_id.amount_total)
+            terms = self.invoice_id.invoice_payment_term_id.compute(
+                self.invoice_id.amount_total
+            )
             if terms:
                 # Returns all payment and their date like [('2020-12-07', 430.37), ...]
                 # Get the last payment date in the format "202021207"
                 date_due = terms[-1][0].replace("-", "")
         if not date_due:
-            date_due = self.format_date(self.invoice_id.invoice_date_due or self.invoice_id.invoice_date)
+            date_due = self.format_date(
+                self.invoice_id.invoice_date_due or self.invoice_id.invoice_date
+            )
         params["date_due"] = date_due
         return params
 
     def _get_jinja_env(self, template_dir):
         jinja_env = Environment(
-            loader=FileSystemLoader(template_dir), autoescape=select_autoescape(["xml"]),
+            loader=FileSystemLoader(template_dir),
+            autoescape=select_autoescape(["xml"]),
         )
         return jinja_env
 

ebill_paynet/tests/__init__.py

@@ -1,4 +1,5 @@
 from . import test_ebill_paynet
+
 # Test for the B2C implemenation wich is not done, yet
 # from . import test_invoice_message
 from . import test_invoice_message_b2b

ebill_paynet/tests/common.py

@@ -2,17 +2,15 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
 import os
-
 from os.path import dirname, join
 
 from vcr import VCR
+from xmlunittest import XmlTestMixin
 
 from odoo.tests.common import SavepointCase
-from xmlunittest import XmlTestMixin
 
 
 class CommonCase(SavepointCase, XmlTestMixin):
-
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -186,7 +184,6 @@ def setUpClass(cls):
         cls.invoice.invoice_payment_ref = "1234567890"
         cls.invoice.invoice_partner_bank_id = cls.partner_bank.id
 
-
     @staticmethod
     def compare_xml_line_by_line(content, expected):
         """This a quick way to check the diff line by line to ease debugging"""
@@ -199,6 +196,7 @@ def compare_xml_line_by_line(content, expected):
                     i, number_of_lines, expected_line[i], generated_line[i],
                 )
 
+
 def get_recorder(base_path=None, **kw):
     base_path = base_path or dirname(__file__)
     defaults = dict(
@@ -212,4 +210,5 @@ def get_recorder(base_path=None, **kw):
     defaults.update(kw)
     return VCR(**defaults)
 
+
 recorder = get_recorder()

ebill_paynet/tests/test_invoice_message_b2b.py

@@ -20,7 +20,7 @@ def setUpClass(cls):
     def test_invoice(self):
         """ Check XML payload genetated for an invoice."""
         self.invoice.name = "INV_TEST_01"
-        self.invoice.invoice_date_due = '2019-07-01'
+        self.invoice.invoice_date_due = "2019-07-01"
         message = self.invoice.create_paynet_message()
         message.payload = message._generate_payload()
         # Remove the PDF file data from the XML to ease testing

ebill_paynet_account_financial_discount/__manifest__.py

@@ -8,9 +8,6 @@
     "license": "AGPL-3",
     "author": "Camptocamp SA,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/l10n-switzerland",
-    "depends": [
-        "account_financial_discount",
-        "ebill_paynet",
-    ],
+    "depends": ["account_financial_discount", "ebill_paynet"],
     "auto_install": True,
 }

ebill_paynet_account_financial_discount/models/paynet_invoice_message.py

@@ -22,10 +22,11 @@ def _get_payload_params(self):
         params = super()._get_payload_params()
         params["discount_template"] = DISCOUNT_TEMPLATE
         discount = {}
-        if self.invoice_id.invoice_payment_term_id and self.invoice_id.invoice_payment_term_id.percent_discount:
+        if self.invoice_id.invoice_payment_term_id.percent_discount:
+            terms = self.invoice_id.invoice_payment_term_id
             discount = {
-                "percentage": self.invoice_id.invoice_payment_term_id.percent_discount,
-                "days": self.invoice_id.invoice_payment_term_id.days_discount
+                "percentage": terms.percent_discount,
+                "days": terms.days_discount,
             }
         params["discount"] = discount
         return params

ebill_paynet_account_financial_discount/tests/test_ebill_paynet_account_financial_discount.py

@@ -1,9 +1,10 @@
 # Copyright 2020 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
-from freezegun import freeze_time
 from string import Template
 
+from freezegun import freeze_time
+
 from odoo.tools import file_open
 
 from ...ebill_paynet.tests.common import CommonCase
@@ -15,19 +16,19 @@ class TestEbillPaynetAccountFinancialDiscount(CommonCase):
     def setUpClass(cls):
         super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
-        cls.payment_term = cls.env['account.payment.term'].create(
+        cls.payment_term = cls.env["account.payment.term"].create(
             {
-                'name': 'Skonto',
-                'days_discount': 10,
-                'percent_discount': 2.0,
-                'line_ids': [
+                "name": "Skonto",
+                "days_discount": 10,
+                "percent_discount": 2.0,
+                "line_ids": [
                     (
                         0,
                         0,
                         {
-                            'value': 'balance',
-                            'days': 60,
-                            'option': 'day_after_invoice_date',
+                            "value": "balance",
+                            "days": 60,
+                            "option": "day_after_invoice_date",
                         },
                     )
                 ],
@@ -37,7 +38,7 @@ def setUpClass(cls):
     def test_invoice(self):
         """ Check XML payload genetated for an invoice."""
         self.invoice.name = "INV_TEST_01"
-        self.invoice.invoice_date_due = '2019-07-01'
+        self.invoice.invoice_date_due = "2019-07-01"
         self.invoice.invoice_payment_term_id = self.payment_term
         message = self.invoice.create_paynet_message()
         message.payload = message._generate_payload()
@@ -51,7 +52,9 @@ def test_invoice(self):
         self.assertXmlDocument(payload)
         # Prepare the XML file that is expected
         expected_tmpl = Template(
-            file_open("ebill_paynet_account_financial_discount/tests/examples/invoice_b2b.xml").read()
+            file_open(
+                "ebill_paynet_account_financial_discount/tests/examples/invoice_b2b.xml"
+            ).read()
         )
         expected = expected_tmpl.substitute(IC_REF=message.ic_ref).encode("utf8")
         # Remove the comments in the expected xml

setup/ebill_paynet_account_financial_discount/odoo/addons/ebill_paynet_account_financial_discount

@@ -0,0 +1 @@
+../../../../ebill_paynet_account_financial_discount

setup/ebill_paynet_account_financial_discount/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)