[MIG] l10n_ch_payment_slip: Migration to 11.0 #373

yvaucher · 2017-11-17T17:13:52Z

Update headers
Port code to python3
Update README
Fix tests with correct report render calls
Adapt code to report module split

TODO:

fixing tests
v11 + tests -> moved in another module
put bvr parameters on res.confing.settings
edit README.rst to explain the difference with Odoo official addon.

grindtildeath

https://github.com/OCA/l10n-switzerland/pull/373/files#diff-788bc5e9535f52e4fdb14b3cf5d6a2e2R15

odoo.report doesn't exist in v11, so it crashes if submodule is in addons_path

2017-11-20 16:18:15,761 1 ERROR ? werkzeug: Error on request:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/werkzeug/serving.py", line 193, in run_wsgi
    execute(self.server.app)
  File "/usr/local/lib/python3.5/dist-packages/werkzeug/serving.py", line 181, in execute
    application_iter = app(environ, start_response)
  File "/opt/odoo/src/odoo/service/server.py", line 251, in app
    return self.app(e, s)
  File "/opt/odoo/src/odoo/service/wsgi_server.py", line 166, in application
    return application_unproxied(environ, start_response)
  File "/opt/odoo/src/odoo/service/wsgi_server.py", line 154, in application_unproxied
    result = handler(environ, start_response)
  File "/opt/odoo/src/odoo/http.py", line 1297, in __call__
    self.load_addons()
  File "/opt/odoo/src/odoo/http.py", line 1319, in load_addons
    m = __import__('odoo.addons.' + module)
  File "/opt/odoo/src/odoo/modules/module.py", line 82, in load_module
    exec(open(modfile, 'rb').read(), new_mod.__dict__)
  File "<string>", line 1, in <module>
    
  File "/opt/odoo/external-src/l10n-switzerland/l10n_ch_payment_slip/models/__init__.py", line 2, in <module>
    from . import payment_slip
  File "/opt/odoo/external-src/l10n-switzerland/l10n_ch_payment_slip/models/payment_slip.py", line 15, in <module>
    from odoo.report import report_sxw
ImportError: No module named 'odoo.report'

simahawk

LGTM, just nitpicking non-blocking comments ;)

simahawk · 2018-01-19T08:30:28Z

l10n_ch_payment_slip/__manifest__.py

@@ -1,32 +1,28 @@
-# -*- coding: utf-8 -*-
-# © 2012-2016 Camptocamp SA
+# Copyright 2012-2016 Camptocamp SA


2012-2018, same for other py files

When significant changes were made in py files I updated it already (was in 2017 BTW)

simahawk · 2018-01-19T08:31:55Z

l10n_ch_payment_slip/models/company.py

 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 from odoo import models, fields


 class ResCompany(models.Model):
-    """override company in order to add bvr vertical and
+    """override company in order to add ISR vertical and


"""Add ISR vertical and Horizontal print delta."""

simahawk · 2018-01-19T08:33:29Z

l10n_ch_payment_slip/models/invoice.py

@@ -24,8 +23,8 @@ class AccountMoveLine(models.Model):


 class AccountInvoice(models.Model):
-    """Inherit account.invoice in order to add bvr
-    printing functionnalites. BVR is a Swiss payment vector"""
+    """Inherit account.invoice in order to add ISR


"""Add ISR (Swiss payment vector) printing features."""

simahawk · 2018-01-19T08:34:39Z

l10n_ch_payment_slip/report/ir_action.py

+    @api.multi
+    def _generate_one_slip_per_page_from_invoice_pdf(self, report_name=None):
+        """Generate payment slip PDF(s) from report model.
+        If there is many pdf they are merged in memory or on


blank line after 1st one.

simahawk · 2018-01-19T08:35:15Z

l10n_ch_payment_slip/report/ir_action.py

+    @api.multi
+    def _generate_one_slip_per_page_from_invoice_pdf(self, report_name=None):
+        """Generate payment slip PDF(s) from report model.
+        If there is many pdf they are merged in memory or on


"If there are many PDF..."

grindtildeath

Maybe we need this commit ?
266e82d

Also I think we should add a dependency on contacts because that's where the res.bank and res.partner.bank menus are defined, and we need these to configure the module properly.

Moreover I get an error when I try to print ISR :



Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/src/addons/web/controllers/main.py", line 77, in wrap
    return f(*args, **kwargs)
  File "/opt/odoo/src/addons/web/controllers/main.py", line 1527, in index
    action["report_name"], report_ids, report_data, context])
  File "/opt/odoo/src/odoo/http.py", line 115, in dispatch_rpc
    result = dispatch(method, params)
UnboundLocalError: local variable 'dispatch' referenced before assignment

grindtildeath · 2018-02-01T14:32:47Z

l10n_ch_payment_slip/views/company.xml

@@ -2,25 +2,25 @@
 <openerp>
    <data>
       <record model="ir.ui.view" id="company_form_view">
-            <field name="name">res.company.form.inherit.bvr</field>
+            <field name="name">res.company.form.inherit.isr</field>
            <field name="model">res.company</field>
            <field name="inherit_id" ref="base.view_company_form"/>


IMO would be nice to move these settings from the company from view to res.config.settings

Edit : Didn't see you todo ;)

grindtildeath · 2018-02-01T15:15:12Z

l10n_ch_payment_slip/__manifest__.py

-     'base',
-     'account',
-     'report',
+     'account_invoicing',
     'l10n_ch_base_bank',
     'base_transaction_id',  # OCA/bank-statement-reconcile


OCA/account-reconcile

grindtildeath · 2018-02-01T15:19:31Z

l10n_ch_payment_slip/tests/test_payment_slip.py

+        self.report1slip_from_inv = self.env.ref(
+            'l10n_ch_payment_slip.one_slip_per_page_from_invoice',
+        )
+
    def make_bank(self):


Would be great to have these records as demo data as it's impossible to test functionally without it.

tschanzt

👍 if you get travis to run.

tschanzt · 2018-02-05T17:18:40Z

l10n_ch_payment_slip/models/company.py

+    isr_delta_horz = fields.Float(
+        'ISR Horz. Delta (inch)',
+        oldname='bvr_delta_horz',
+        help='horiz. delta in inch 1.2 will print the ISR 1.2 inch lefter,'


lefter sounds weird. to the left?

yvaucher · 2018-04-19T15:10:07Z

I'll close this PR as odoo is now managing the payment slip officially again.

If the official module lacks features we can still create other modules. On the other hand it might not be the right time to make lot of changes as the QR invoices will replace this.

yvaucher · 2018-06-22T15:06:31Z

Reopened as official module is currently not providing all required features. (alignment on printout, reconciliation based on BVR reference)

grindtildeath · 2018-06-25T13:37:19Z

@TDu Can you please integrate the content of this PR as well ? #411

TDu · 2018-06-25T13:54:03Z

@grindtildeath It has been merged in 10.0, are you asking to add it to 11.0 ?

TDu · 2018-06-26T07:34:12Z

@grindtildeath Will look at it when I get a green Travis.

TDu · 2018-06-26T14:59:46Z

@grindtildeath Unfortunately it is not straightforward to incorporate your PR in 11.0. Some methods have moved or been dropped, could you have a look at it ?

grindtildeath · 2018-06-29T06:50:18Z

@TDu I cherry-picked and tried to fix but there's a few things not working yet, can you please check it as you already did most of the migration ? Thx
yvaucher#2

Remove the button "Print ISR" on invoices to avoid confusion with Odoo base implementation and rename the one from this module for user consistency

Fix right error on ISR print

BT-ojossen · 2018-09-18T09:11:57Z

hi, what's the state here? when will this be merged?

yvaucher · 2018-09-18T14:41:00Z

@BT-ojossen this is in a ready state, but for the unit tests which are still red. Thus to answer your question, it will be merged when the tests are fixed.

ghost · 2018-09-20T08:51:14Z

l10n_ch_payment_slip/wizard/isr_batch_print.py


-    _name = 'bvr.batch.print.wizard'
+    _name = 'isr.batch.print.wizard'

    invoice_ids = fields.Many2many(comodel_name='account.invoice',
                                   string='Invoices')
    error_message = fields.Text('Errors')


Hi @yvaucher, I think it is a silly mistake but,

When you get the related error in the batch print wizard, the error is editable, in my point of view it is a little bit annoying.

Regards!

@BT-ccebrian makes sense to me.

@grindtildeath can you also add a readonly on that field? AFAIK it should only be set server side.

Fixed in dee27ae

simahawk

LG.
Runbot is not really red, is yellow because of warnings unrelated to this module.

One thing: we might want to mention in a TODO that the merge mode machinery could/should be splitted into reporting-engine module(s)

yvaucher · 2018-09-21T09:05:18Z

@grindtildeath LG thanks for fixing the tests

Restore report_type to reportlab-pdf Improvement to batch wizard, error readonly

`payment_slip._get_address_lines` computes the address of the partner. This is done in an onchange context whereas the changes where not isolated and they were propagated to the real partner via all the onchanges related to it. We spotted the issue on the mail compose wizard whereas the chain of onchanges was wiping all the default values. With this change we: * isolate the partner w/ a fake record * additionally we cache the result per each partner since the function is called several times

grindtildeath

I approve as I'm the author of the last commits 😊

yvaucher mentioned this pull request Nov 17, 2017

[11.0] mig base modules #367

Closed

4 tasks

grindtildeath reviewed Nov 20, 2017

View reviewed changes

yvaucher force-pushed the 11.0-mig-l10n_ch_payment_slip branch from 76a6d17 to 8d847b1 Compare November 27, 2017 17:05

yvaucher added the work in progress label Nov 27, 2017

yvaucher force-pushed the 11.0 branch from 320c282 to b8ebe8c Compare December 1, 2017 20:26

yvaucher force-pushed the 11.0-mig-l10n_ch_payment_slip branch from cb767fa to 992605b Compare December 1, 2017 20:40

pedrobaeza mentioned this pull request Dec 20, 2017

Migration to version 11.0 #355

Closed

21 tasks

simahawk requested changes Jan 19, 2018

View reviewed changes

grindtildeath suggested changes Feb 1, 2018

View reviewed changes

tschanzt reviewed Feb 5, 2018

View reviewed changes

yvaucher closed this Apr 19, 2018

yvaucher reopened this Jun 22, 2018

TDu force-pushed the 11.0-mig-l10n_ch_payment_slip branch 2 times, most recently from 717f064 to 0ab85d3 Compare June 25, 2018 13:32

TDu force-pushed the 11.0-mig-l10n_ch_payment_slip branch from 0ab85d3 to 5ca48fc Compare June 25, 2018 13:43

TDu force-pushed the 11.0-mig-l10n_ch_payment_slip branch 2 times, most recently from 36eaeb6 to f5ad651 Compare June 25, 2018 15:21

TDu force-pushed the 11.0-mig-l10n_ch_payment_slip branch 3 times, most recently from 3e6b0af to 76157af Compare June 26, 2018 11:55

TDu force-pushed the 11.0-mig-l10n_ch_payment_slip branch from 3f0a284 to 7996134 Compare June 26, 2018 15:43

yvaucher mentioned this pull request Jul 4, 2018

Swiss QR Bill/Invoice 30th June 2020 http://qr-bill.ch #416

Closed

yvaucher mentioned this pull request Jul 30, 2018

[11.0][IMP] Remove useless button on invoice #435

Merged

grindtildeath added 2 commits August 20, 2018 19:41

Add test case on attachment management

4b691df

Fix v11 for attachment feature

89cd282

yvaucher force-pushed the 11.0-mig-l10n_ch_payment_slip branch 3 times, most recently from 534ec4a to d963f6e Compare August 21, 2018 08:14

Migration of attachment feature to v11

0f48cf7

yvaucher force-pushed the 11.0-mig-l10n_ch_payment_slip branch from d963f6e to 0f48cf7 Compare August 21, 2018 13:22

p-tombez and others added 4 commits August 23, 2018 17:32

[11.0][IMP] Remove useless button on invoice

a56e552

Remove the button "Print ISR" on invoices to avoid confusion with Odoo base implementation and rename the one from this module for user consistency

Fix dependency to remove std print isr button

a783c17

Fix right error on ISR print

d7f51ad

Merge pull request #5 from p-tombez/11.0-mig-l10n_ch_payment_slip

07616d7

Fix right error on ISR print

ghost reviewed Sep 20, 2018

View reviewed changes

grindtildeath force-pushed the 11.0-mig-l10n_ch_payment_slip branch from 261e6c8 to ba92eef Compare September 20, 2018 15:25

simahawk approved these changes Sep 21, 2018

View reviewed changes

tschanzt approved these changes Sep 21, 2018

View reviewed changes

grindtildeath and others added 6 commits September 21, 2018 11:38

Finish migration to 11.0

e5056a4

Restore report_type to reportlab-pdf Improvement to batch wizard, error readonly

Improve tests and assign bvr_address_format without sudo

8115483

Fix merges methods

5eddc05

Rework save as attachment feature using _post_pdf

a772265

Drop unneeded imports

a1c7d7c

grindtildeath force-pushed the 11.0-mig-l10n_ch_payment_slip branch from ba92eef to 758393a Compare September 21, 2018 09:38

Finally fix the test considering odoo weird behaviour

0e06d3c

grindtildeath force-pushed the 11.0-mig-l10n_ch_payment_slip branch from 758393a to 0e06d3c Compare September 21, 2018 09:52

grindtildeath approved these changes Oct 8, 2018

View reviewed changes

yvaucher merged commit 98de7e4 into OCA:11.0 Oct 16, 2018

yvaucher deleted the 11.0-mig-l10n_ch_payment_slip branch October 17, 2019 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] l10n_ch_payment_slip: Migration to 11.0 #373

[MIG] l10n_ch_payment_slip: Migration to 11.0 #373

yvaucher commented Nov 17, 2017 •

edited

Loading

grindtildeath left a comment

simahawk left a comment

simahawk Jan 19, 2018

yvaucher Jan 25, 2018

simahawk Jan 19, 2018

simahawk Jan 19, 2018

simahawk Jan 19, 2018

simahawk Jan 19, 2018

grindtildeath left a comment

grindtildeath Feb 1, 2018 •

edited

Loading

grindtildeath Feb 1, 2018

grindtildeath Feb 1, 2018

tschanzt left a comment

tschanzt Feb 5, 2018

yvaucher commented Apr 19, 2018

yvaucher commented Jun 22, 2018

grindtildeath commented Jun 25, 2018

TDu commented Jun 25, 2018

TDu commented Jun 26, 2018

TDu commented Jun 26, 2018

grindtildeath commented Jun 29, 2018

BT-ojossen commented Sep 18, 2018

yvaucher commented Sep 18, 2018

ghost Sep 20, 2018

yvaucher Sep 20, 2018 •

edited

Loading

grindtildeath Sep 20, 2018

simahawk left a comment

yvaucher commented Sep 21, 2018

grindtildeath left a comment

[MIG] l10n_ch_payment_slip: Migration to 11.0 #373

[MIG] l10n_ch_payment_slip: Migration to 11.0 #373

Conversation

yvaucher commented Nov 17, 2017 • edited Loading

grindtildeath left a comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath Feb 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschanzt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yvaucher commented Apr 19, 2018

yvaucher commented Jun 22, 2018

grindtildeath commented Jun 25, 2018

TDu commented Jun 25, 2018

TDu commented Jun 26, 2018

TDu commented Jun 26, 2018

grindtildeath commented Jun 29, 2018

BT-ojossen commented Sep 18, 2018

yvaucher commented Sep 18, 2018

Choose a reason for hiding this comment

yvaucher Sep 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

yvaucher commented Sep 21, 2018

grindtildeath left a comment

Choose a reason for hiding this comment

yvaucher commented Nov 17, 2017 •

edited

Loading

grindtildeath Feb 1, 2018 •

edited

Loading

yvaucher Sep 20, 2018 •

edited

Loading