Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] l10n_ch_states #571

Merged
merged 25 commits into from
Sep 14, 2021
Merged

Conversation

yvaucher
Copy link
Member

No description provided.

@yvaucher yvaucher mentioned this pull request Nov 11, 2020
14 tasks
@yvaucher yvaucher force-pushed the 14.0-mig-l10n_ch_states branch from 617ed08 to 469a8a6 Compare February 23, 2021 15:32
@renzo1974
Copy link

@angelmoya @pedrobaeza What is needed that this PR will be merged?

@pedrobaeza
Copy link
Member

You should contact contributors from this PSC, as we don't know about the Swish localization

@yvaucher
Copy link
Member Author

@rm-jamotion usually it's review that are missing.
I'll merge it anyway as this is a straight forward port.

@yvaucher
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-571-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 19, 2021
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-571-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Copy link
Member

@angelmoya angelmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@angelmoya
Copy link
Member

@rm-jamotion Nice to see you !

You can review code and/or functionality on runbot, then you can add a review, with reviews a manager can merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-571-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f7a1dd5 into OCA:14.0 Sep 14, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6c40ed9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.