Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] server_env_ebill_paynet: Migration to 14.0 #596

Merged
merged 9 commits into from
Oct 19, 2021
Merged

[MIG] server_env_ebill_paynet: Migration to 14.0 #596

merged 9 commits into from
Oct 19, 2021

Conversation

dzungtran89
Copy link
Contributor

Dependencies:

Notes:

  • This module is migrated from this commit

@dzungtran89 dzungtran89 mentioned this pull request Feb 28, 2021
Open
14 tasks
@dzungtran89 dzungtran89 force-pushed the 14.0-mig-server_env_ebill_paynet branch 2 times, most recently from 2477a02 to 2af5bad Compare March 1, 2021 10:04
@mmequignon
Copy link
Member

I think we are losing the git history here.

@dzungtran89
Copy link
Contributor Author

thx @mmequignon , I'll update it

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-server_env_ebill_paynet branch 2 times, most recently from 06dcf0c to 5385c0c Compare September 14, 2021 05:42
@hailangvn hailangvn force-pushed the 14.0-mig-server_env_ebill_paynet branch from 5385c0c to 510237d Compare September 14, 2021 07:41
@hailangvn
Copy link
Contributor

We will fix the travis.

@hailangvn hailangvn force-pushed the 14.0-mig-server_env_ebill_paynet branch from 510237d to 12f57a2 Compare September 16, 2021 15:07
@hailangvn
Copy link
Contributor

The travis is green now.

@TDu
Copy link
Member

TDu commented Oct 12, 2021

Looks like you lost some information on the migration https://github.com/OCA/l10n-switzerland/blob/13.0/server_env_ebill_paynet/readme/CONTRIBUTORS.rst

@dzungtran89
Copy link
Contributor Author

I had thought that I would update it in this #596, is it okay to you?

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-server_env_ebill_paynet branch from 12f57a2 to 30138b9 Compare October 12, 2021 08:34
@dzungtran89
Copy link
Contributor Author

Hi @TDu , the PR has been updated, it's synced with your readme fix in the PR #623

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TDu
TDu approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzungtran89 Thanks for fixing it

@TDu
Copy link
Member

TDu commented Oct 15, 2021

@dzungtran89 all dependencies have been merged. You can update test-requirements.txt

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-server_env_ebill_paynet branch from 30138b9 to cc399be Compare October 15, 2021 11:54
@dzungtran89
Copy link
Contributor Author

Hi @TDu , the PR has been updated

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-596-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9189e53 into OCA:14.0 Oct 19, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a0d5e4b. Thanks a lot for contributing to OCA. ❤️

@hailangvn hailangvn deleted the 14.0-mig-server_env_ebill_paynet branch October 19, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@leemannd leemannd leemannd approved these changes

@sebalix sebalix sebalix approved these changes

@mmequignon mmequignon mmequignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dzungtran89 @mmequignon @hailangvn @TDu @OCA-git-bot @simahawk @leemannd @sebalix @oca-travis