Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_ch_pain_direct_debit : Migration to 14.0 #704

Closed
wants to merge 23 commits into from
Closed

[14.0][MIG] l10n_ch_pain_direct_debit : Migration to 14.0 #704

wants to merge 23 commits into from

Conversation

ecino
Copy link

@ecino ecino commented Jun 5, 2023

Depends on l10n_ch_pain_base.

@ecino ecino mentioned this pull request Jun 5, 2023
Open
14 tasks
@ecino ecino force-pushed the 14.0-pain-direct-debit branch from 1ce824f to 86846a6 Compare June 5, 2023 10:16
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@ecino
Copy link
Author

ecino commented Oct 30, 2023

Still waiting for pain_base module to be available.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@ecino ecino force-pushed the 14.0-pain-direct-debit branch 7 times, most recently from 14c585f to 656147d Compare December 14, 2023 14:40
@ecino ecino force-pushed the 14.0-pain-direct-debit branch 3 times, most recently from 58824da to 176338a Compare December 18, 2023 07:39
@ecino
Copy link
Author

ecino commented Dec 18, 2023

Last bit of the pain modules for Switzerland. After this being merged, I will probably migrate them in the newer versions and put them as a single pull request. @alexis-via Would you like reviewing this one? I think it was never implemented completely at the time the module was published, but this version should be working.

@yvaucher I wanted to add the "Postfinance Bank Account" in the demo data of the l10n_ch_base_bank module, for using it in the tests. But by doing so, the tests of the modules did break and I had to change a few things, but I'm not completely sure if all changes are ok. Would you like to check the changes in this module?

@ecino
Copy link
Author

ecino commented Jan 18, 2024

@alexis-via @TDu @yvaucher can someone review this one?

alexis-via and others added 12 commits February 27, 2024 08:28
@alexis-via @ecino
Migrate to a new architecture with 3 modules for PAIN
06dd03f
@pedrobaeza @ecino
[MIG] Rename manifest files
b1212aa
@Nooka10 @ecino
[11.0][MIG] l10n_ch_pain_direct_debit and l10n_ch_lsv_dd
f64561c 
I merge the l10n_ch_lsv_dd module into the l10n_ch_pain_direct_debit module.
correct lint and tests
@ecino
Add migration scripts for databases that had lsv_dd module installed.
083d7e2
@quentingigon @ecino
fixed tests for v12.0
e7df0d8
@quentingigon @ecino
moved some demo data from direct_debit to base_bank to simplify tests…
40c0b5f 
… and rolled back my previous changes
@ecino
WIP adapt generate_start_payment_info_block signature for sepa-non-sepa
a4af107
@ecino
FIX show_invoices
5e080f4
@quentingigon @ecino
CO-3145 FIX pain_direct_debit for Postfinance
5b587d6 
xml file is now correctly generated for various bank formats

added some pre-processing in the case of a LSV+
@quentingigon @ecino
fix for local_instrument set when added to inbound payment order
1d9d06d
@quentingigon @ecino
updated comment at beginning of file
0d6805b
@ecino
FIX again direct debit generation
3092cc4
@ecino ecino force-pushed the 14.0-pain-direct-debit branch from 176338a to 31452c8 Compare February 27, 2024 07:29
@TDu
Copy link
Member

TDu commented May 31, 2024

@ecino Hello, could you fix the pre-commit error and rebase if needed ? Thank you

@davidwul
Copy link
Contributor

@TDu
rebased and pre-commit fixed

@davidwul davidwul mentioned this pull request Jun 12, 2024
Closed
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ecino @TDu @davidwul @alexis-via @pedrobaeza @Nooka10 @quentingigon @wvmrtn @Theyiot @lucadela96