Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Deprecate setup_requires for pyproject.toml #400

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

chienandalu
Copy link
Member

Follow PEP 517/518 packaging standards to avoid dependency issues.

cc @Tecnativa @josep-tecnativa

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! I was hit by this one as well.

@hparfr
Copy link

hparfr commented Feb 24, 2025

does it replace #287 ?

@pedrobaeza pedrobaeza force-pushed the fix-setuptools_scm-version branch from ee8f6ae to 7c87ea6 Compare February 24, 2025 14:17
@pedrobaeza pedrobaeza mentioned this pull request Feb 24, 2025
@pedrobaeza pedrobaeza force-pushed the fix-setuptools_scm-version branch from 7c87ea6 to 6387f0b Compare February 24, 2025 14:29
@pedrobaeza pedrobaeza force-pushed the fix-setuptools_scm-version branch from 6387f0b to 2f9fdcb Compare February 24, 2025 14:44
Follow PEP 517/518 packaging standards to avoid dependency issues.

The old definition is kept for Python 2.7, as it seems to be
incompatible.
@pedrobaeza pedrobaeza force-pushed the fix-setuptools_scm-version branch from 2f9fdcb to 83a4293 Compare February 24, 2025 14:53
@pedrobaeza
Copy link
Member

@sbidoul as you are the expert on "pip" thing, please give your final blessing to merge this and fix the problem in deployments.

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, and produces the same openupgradelib wheel as before. So 👍

@pedrobaeza pedrobaeza merged commit ec6b3e6 into OCA:master Feb 24, 2025
2 checks passed
@pedrobaeza pedrobaeza deleted the fix-setuptools_scm-version branch February 24, 2025 15:08
@pedrobaeza
Copy link
Member

Published a new version without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants