-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Deprecate setup_requires for pyproject.toml #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank! I was hit by this one as well.
does it replace #287 ? |
ee8f6ae
to
7c87ea6
Compare
7c87ea6
to
6387f0b
Compare
6387f0b
to
2f9fdcb
Compare
Follow PEP 517/518 packaging standards to avoid dependency issues. The old definition is kept for Python 2.7, as it seems to be incompatible.
2f9fdcb
to
83a4293
Compare
@sbidoul as you are the expert on "pip" thing, please give your final blessing to merge this and fix the problem in deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good, and produces the same openupgradelib wheel as before. So 👍
Published a new version without problems. |
Follow PEP 517/518 packaging standards to avoid dependency issues.
cc @Tecnativa @josep-tecnativa