Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: provide base64 lib to lua - v5 #12575

Closed
wants to merge 4 commits into from
Closed

Conversation

jasonish
Copy link
Member

A no padding option is provided as a mode, as its a variant suitable
for encoding and decoding.

A padding optional function is added that is indifferent to padding
when decoding. This can be useful when you're not sure if padding
exists, and don't really care.
Export our base64 decoding and encoding functions to Lua.

Ticket: OISF#7074
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (3831843) to head (1d3e290).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12575   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files         929      930    +1     
  Lines      259062   259129   +67     
=======================================
+ Hits       209119   209181   +62     
- Misses      49943    49948    +5     
Flag Coverage Δ
fuzzcorpus 56.94% <11.76%> (-0.02%) ⬇️
livemode 19.41% <0.00%> (+0.02%) ⬆️
pcap 44.19% <0.00%> (+<0.01%) ⬆️
suricata-verify 63.42% <88.23%> (+0.03%) ⬆️
unittests 58.34% <21.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Feb 13, 2025
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24718

@victorjulien
Copy link
Member

Merged in #12579, thanks!

@jasonish jasonish deleted the lua-base64/v5 branch February 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants