Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/720/20250214/v1 #12581

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

victorjulien
Copy link
Member

It had a rather generic name of "path", which in Lua usually means a
search path, which we'll be adding.
By default, use an empty search path. This gives us a predictable
default. If a user needs access to external modules, the search path
must be set in the configuration file.

Ticket: OISF#7169
- Sandboxed Lua for rules
- Search path changes for Lua output scripts
@victorjulien victorjulien requested review from jufajardini and a team as code owners February 14, 2025 09:55
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (c6d038b) to head (97e01a8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12581      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files         930      930              
  Lines      259129   259150      +21     
==========================================
  Hits       209187   209187              
- Misses      49942    49963      +21     
Flag Coverage Δ
fuzzcorpus 56.92% <0.00%> (-0.02%) ⬇️
livemode 19.38% <0.00%> (-0.01%) ⬇️
pcap 44.16% <0.00%> (+<0.01%) ⬆️
suricata-verify 63.41% <86.20%> (-0.01%) ⬇️
unittests 58.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24727

@jasonish
Copy link
Member

Run curl https://sh.rustup.rs/ -sSf | sh -s -- --default-toolchain $(grep rust-version rust/Cargo.toml.in|sed 's/\"//g'|awk '{print $3}') -y
curl: (7) Failed to connect to sh.rustup.rs port 443 after 7205 ms: Couldn't connect to server

I wonder if we need to wrap this in a loop for a few retries.

@victorjulien victorjulien merged commit 97e01a8 into OISF:master Feb 14, 2025
60 checks passed
@victorjulien victorjulien deleted the next/720/20250214/v1 branch February 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants