zarr_driver.py: Minor cleanup. #11896
Open
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Break up massive wkt string in test_zarr_read_crs - Wrap a few places with gdal.quiet_errors where ZARR_V3 gives "Warning 1: fill_value = null is invalid" on open - Remove a commented out debugging print
dbaston
reviewed
Mar 1, 2025
| @@ -5498,7 +5514,9 @@ def test_zarr_driver_rename(format): | |||
| try: | |||
| drv.Create(filename, 1, 1, options=["FORMAT=" + format]) | |||
|
|
|||
| assert gdal.Open(filename) | |||
| with gdal.quiet_errors(): | |||
There was a problem hiding this comment.
I'm thinking a gdal.quiet_warnings() would be a good idea (I'm happy to implement it)
There was a problem hiding this comment.
If you are up for it, gdal.quiet_warnings() seems like a nice addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_zarr_read_crsgdal.quiet_errorswhere ZARR_V3 gives "Warning 1: fill_value = null is invalid" on open