Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Backport missing dependency in NewTabPage #816

Merged
merged 1 commit into from
May 22, 2024
Merged

chromium: Backport missing dependency in NewTabPage #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions meta-chromium/recipes-browser/chromium/chromium-gn.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ B = "${S}/${OUTPUT_DIR}"
# Backported patches.
SRC_URI += "\
file://backport/Add-missing-components-enterprise-buildflag.patch \
file://backport/NewTabPage-Add-missing-dep-to-cr_components.patch \
"

# Non-specific patches.
Expand Down
27 changes: 27 additions & 0 deletions ...recipes-browser/chromium/files/backport/NewTabPage-Add-missing-dep-to-cr_components.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From bd53e2fcd2ff2ab5f9726753b827e7f958ad1041 Mon Sep 17 00:00:00 2001
From: dpapad <[email protected]>
Date: Wed, 27 Mar 2024 23:05:52 +0000
Subject: [PATCH] Backport "NewTabPage: Add missing dep to
cr_components/history_clusters/."

This fixes transient build error caused by missing dependency.
The patch will be included in upstream's 125 release.

Upstream-Status: Backport [https://crrev.com/c/5402989]
Signed-off-by: Daniel Semkowicz <[email protected]>
---
chrome/browser/resources/new_tab_page/BUILD.gn | 1 +
1 file changed, 1 insertion(+)

diff --git a/chrome/browser/resources/new_tab_page/BUILD.gn b/chrome/browser/resources/new_tab_page/BUILD.gn
index 83736b4..64b5a0b 100644
--- a/chrome/browser/resources/new_tab_page/BUILD.gn
+++ b/chrome/browser/resources/new_tab_page/BUILD.gn
@@ -104,6 +104,7 @@ build_webui("build") {
"//ui/webui/resources/cr_components/color_change_listener:build_ts",
"//ui/webui/resources/cr_components/customize_themes:build_ts",
"//ui/webui/resources/cr_components/help_bubble:build_ts",
+ "//ui/webui/resources/cr_components/history_clusters:build_ts",
"//ui/webui/resources/cr_components/most_visited:build_ts",
"//ui/webui/resources/cr_components/omnibox:build_ts",
"//ui/webui/resources/cr_components/page_image_service:build_ts",