Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v2.0.0 #697

Merged
merged 84 commits into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
25bfed6
rm language support
cpholguera Feb 17, 2023
f5488ee
add info about arch and ecosystem replacing MASVS-ARCH
cpholguera Feb 17, 2023
7f60610
update all categories to v2
cpholguera Feb 17, 2023
7c5a287
update Open Worldwide Application Security Project
cpholguera Mar 3, 2023
92461b4
update frontispiece and categories descriptions
cpholguera Mar 4, 2023
1072e3a
update cover
cpholguera Mar 5, 2023
55588e0
rm docx, fix title for exported docs, try new font
cpholguera Mar 5, 2023
8b194c7
restore font
cpholguera Mar 5, 2023
4c5ce1f
change toc depth
cpholguera Mar 5, 2023
48d2d0b
fix upload files
cpholguera Mar 5, 2023
242fed8
fix mv files
cpholguera Mar 5, 2023
811f5ed
list docs
cpholguera Mar 5, 2023
5c54334
fix upload files
cpholguera Mar 5, 2023
741b181
add ls files
cpholguera Mar 5, 2023
c34ff66
use current branch
cpholguera Mar 5, 2023
064afac
rm some files
cpholguera Mar 5, 2023
8a25c6e
add images
cpholguera Mar 5, 2023
8644051
fix frontispiece and readme
cpholguera Mar 5, 2023
01d2baf
fix mdlint
cpholguera Mar 5, 2023
3713531
simplify docgen
cpholguera Mar 5, 2023
2baba3d
fix img link
cpholguera Mar 5, 2023
e649f8a
fix imgs
cpholguera Mar 5, 2023
6d78077
add pagebreaks
cpholguera Mar 5, 2023
b3f67b4
rm langs.md
cpholguera Mar 5, 2023
f22f414
add new masvs yaml and update PDF generation
cpholguera Mar 6, 2023
f98b459
fix file filter
cpholguera Mar 6, 2023
b8c0081
fix file filter line and rm export job
cpholguera Mar 6, 2023
29a62c7
add pagebreaks
cpholguera Mar 6, 2023
2a44020
update actions to v3
cpholguera Mar 6, 2023
5998645
fiy masvs version in yaml
cpholguera Mar 6, 2023
c28575c
increase toc level
cpholguera Mar 6, 2023
4395f22
fix cover
cpholguera Mar 6, 2023
d5ee013
try without headers
cpholguera Mar 6, 2023
bd2b1fd
fix version in cover
cpholguera Mar 6, 2023
b098262
add spacing
cpholguera Mar 6, 2023
49efabe
force newline
cpholguera Mar 6, 2023
1c699c4
add controls individual md files and base category md files
cpholguera Mar 6, 2023
8efb889
rm masvs.yaml
cpholguera Mar 6, 2023
a4bb4f0
autogen yaml
cpholguera Mar 6, 2023
a1fad68
cleanup and update workflows
cpholguera Mar 11, 2023
f006321
cleanup imgs and optimize script
cpholguera Mar 11, 2023
3b7d008
add author
cpholguera Mar 11, 2023
b1723f0
fix spell checker name and words
cpholguera Mar 11, 2023
7bd9fdf
fix statement vs control vs req
cpholguera Mar 13, 2023
9e3a8ec
update cover
cpholguera Mar 13, 2023
10614f6
rm levels from foreword
cpholguera Mar 16, 2023
5483d8b
move contributors to mas website
cpholguera Mar 16, 2023
3fae1bc
update using the MASVS
cpholguera Mar 16, 2023
9b05597
shorten authors to fit in page
cpholguera Mar 16, 2023
89d7f5c
update cover.png
cpholguera Mar 16, 2023
2961095
small change and test
sven-schleier-phoenix Mar 22, 2023
fe01c28
small change and test
sven-schleier-phoenix Mar 22, 2023
5f34f10
small change and test
sven-schleier-phoenix Mar 22, 2023
0c70a4e
small change and test
sushi2k Mar 22, 2023
7737b10
Apply suggestions from code review
cpholguera Mar 28, 2023
0061858
Update Document/05-MASVS-STORAGE.md
cpholguera Mar 28, 2023
71205b1
Update Document/06-MASVS-CRYPTO.md
cpholguera Mar 28, 2023
52f9eae
rm extra new line
cpholguera Mar 28, 2023
26a3c8a
cleanup
cpholguera Mar 31, 2023
d35e874
Update Document/05-MASVS-STORAGE.md
TheDauntless Mar 31, 2023
4114641
minor fixes
cpholguera Mar 31, 2023
42fed06
Merge branch 'upgrading-to-v2.0.0' of https://github.com/OWASP/owasp-…
cpholguera Mar 31, 2023
88bab5a
include masvs version in the yaml
cpholguera Mar 31, 2023
11e0517
Update Document/08-MASVS-NETWORK.md
TheDauntless Mar 31, 2023
fa00574
Update controls/MASVS-CODE-3.md
TheDauntless Mar 31, 2023
5cf98b1
Update controls/MASVS-PLATFORM-1.md
TheDauntless Mar 31, 2023
7f1fb55
Update controls/MASVS-STORAGE-1.md
TheDauntless Mar 31, 2023
9f4645b
Update controls/MASVS-NETWORK-2.md
TheDauntless Mar 31, 2023
77f7003
Update Document/09-MASVS-PLATFORM.md
TheDauntless Mar 31, 2023
6c4bcc8
Update Document/02-Frontispiece.md
TheDauntless Mar 31, 2023
6a113ed
Update Document/09-MASVS-PLATFORM.md
TheDauntless Mar 31, 2023
546b251
Update controls/MASVS-AUTH-3.md
TheDauntless Mar 31, 2023
ae5bb54
Update Document/07-MASVS-AUTH.md
sushi2k Mar 31, 2023
2e72284
fix version write to yaml
cpholguera Mar 31, 2023
5958e37
Merge branch 'upgrading-to-v2.0.0' of https://github.com/OWASP/owasp-…
cpholguera Mar 31, 2023
504886b
Fix whitespace and url
TheDauntless Mar 31, 2023
5be1a52
Trim whitespace
TheDauntless Mar 31, 2023
ae33bf4
Fix URL markdown
TheDauntless Mar 31, 2023
1d1bbd5
Merge branch 'master' of https://github.com/OWASP/owasp-masvs into up…
cpholguera Mar 31, 2023
d2c726b
Merge branch 'upgrading-to-v2.0.0' of https://github.com/OWASP/owasp-…
cpholguera Mar 31, 2023
f95be4f
fix control description for clarity
cpholguera Mar 31, 2023
137e408
fix control wording and order of MASVS IDs
cpholguera Mar 31, 2023
4ab06f8
disable img captions
cpholguera Mar 31, 2023
f1c0b62
disable img captions
cpholguera Mar 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v3

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/config/.markdownlint.json

This file was deleted.

18 changes: 0 additions & 18 deletions .github/workflows/config/mlc_config.json

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"ignorePatterns": [
{
"pattern": "https://www.microsoft.com/en-us/securityengineering/sdl/"
"pattern": "changelog"
}
],
"httpHeaders": [
Expand Down
45 changes: 0 additions & 45 deletions .github/workflows/doc-gen-reusable.yml

This file was deleted.

184 changes: 30 additions & 154 deletions .github/workflows/docgenerator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,178 +8,57 @@ jobs:
## Use `pandocker-tag: TAG=latest-ubuntu-full` for langs that require the special fonts (Russian, Chinese, etc.)
##

en:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document
language: English
lang: en

de:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-de
language: German
lang: de

es:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-es
language: Spanish
lang: es

fr:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-fr
language: French
lang: fr

ptbr:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-ptbr
language: Brazilian Portuguese
lang: ptbr

ptpt:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-ptpt
language: Portugal Portuguese
lang: ptpt

tr:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-tr
language: Turkish
lang: tr
pandocker-tag: TAG=latest-ubuntu-full

gr:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-gr
language: Hindi
lang: gr
pandocker-tag: TAG=latest-ubuntu-full

hi:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-hi
language: Hindi
lang: hi
pandocker-tag: TAG=latest-ubuntu-full

ja:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-ja
language: Japanese
lang: ja
pandocker-tag: TAG=latest-ubuntu-full

ko:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-ko
language: Korean
lang: ko
pandocker-tag: TAG=latest-ubuntu-full

ru:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-ru
language: Russian
lang: ru
pandocker-tag: TAG=latest-ubuntu-full

fa:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-fa
language: Persian
lang: fa
pandocker-tag: TAG=latest-ubuntu-full

zhcn:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-zhcn
language: Simplified Chinese
lang: zhcn
pandocker-tag: TAG=latest-ubuntu-full

zhtw:
uses: OWASP/owasp-masvs/.github/workflows/doc-gen-reusable.yml@master
with:
folder: Document-zhtw
language: Traditional Chinese
lang: zhtw
pandocker-tag: TAG=latest-ubuntu-full

export:
Generate-MASVS-Documents:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 1

# tag name with the latest tag
# and the abbreviated hash of the most recent commit
- name: Set VERSION to env
run: echo "VERSION=$(curl -s https://api.github.com/repos/OWASP/owasp-masvs/tags | jq '.[0].name' | sed 's/\"//g')" >> $GITHUB_ENV

- name: Set DEV VERSION if it's not a tag
if: ${{ !startsWith(github.ref, 'refs/tags/') }}
run: echo "VERSION=${{env.VERSION}}-$(git rev-parse --short HEAD)" >> $GITHUB_ENV

- name: Install pyyaml
run: pip3 install pyyaml
- name: Generate MASVS yaml
run: python3 ./tools/generate_masvs_yaml.py -v ${{ env.VERSION }}

- name: Generate CSV
run: cd tools && python3 export.py --format csv --lang en > OWASP_MASVS-${{env.VERSION}}.csv
- name: Generate JSON
run: cd tools && python3 export.py --format json --lang en > OWASP_MASVS-${{env.VERSION}}.json
- name: Generate XML
run: cd tools && python3 export.py --format xml --lang en > OWASP_MASVS-${{env.VERSION}}.xml
- name: Generate MASVS YAML
run: cd tools && python3 export.py --format yaml --lang en > OWASP_MASVS-${{env.VERSION}}.yaml
- name: Populate MASVS Categories Markdown Files
run: python3 ./tools/populate_masvs_categories_md.py

- name: Upload CSV
uses: actions/upload-artifact@v2
with:
name: OWASP_MASVS-${{env.VERSION}}.csv
path: tools/OWASP_MASVS-${{env.VERSION}}.csv
- name: Upload JSON
uses: actions/upload-artifact@v2
with:
name: OWASP_MASVS-${{env.VERSION}}.json
path: tools/OWASP_MASVS-${{env.VERSION}}.json
- name: Upload XML
uses: actions/upload-artifact@v2
- name: Generate PDF
run: ./tools/docker/pandoc_makedocs.sh Document ${{ env.VERSION }}

- name: Upload Artifacts
uses: actions/upload-artifact@v3
with:
name: OWASP_MASVS-${{env.VERSION}}.xml
path: tools/OWASP_MASVS-${{env.VERSION}}.xml
name: OWASP_MASVS
path: OWASP_MASVS*

- name: Upload YAML
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: OWASP_MASVS-${{env.VERSION}}.yaml
path: tools/OWASP_MASVS-${{env.VERSION}}.yaml
name: OWASP_MASVS.yaml
path: masvs.yaml

release:
runs-on: ubuntu-latest
needs: [en, de, fa, es, fr, hi, ja, ko, ptbr, ptpt, ru, zhcn, zhtw, export]
needs: [Generate-MASVS-Documents]
if: startsWith(github.ref, 'refs/tags/') && (github.actor == 'cpholguera' || github.actor == 'sushi2k')
steps:
- uses: actions/download-artifact@v2
- name: List Downloaded document (sampling of download-artifact)
run: ls -l OWASP_MASVS*

- name: print working directory
run: pwd
- name: Listing of root directory
run: ls -l

- name: Move all translations (pdf, epub and docx) to root
run: mv OWASP_MASVS-*-*/* .
- name: Move all translations (pdf, and epub) to root
run: mv OWASP_MASVS*/* .
- name: Release
uses: softprops/action-gh-release@v1
with:
Expand All @@ -188,11 +67,8 @@ jobs:
generate_release_notes: true
discussion_category_name: Announcements
files: |
OWASP_MASVS-*.pdf
OWASP_MASVS-*.epub
OWASP_MASVS-*.docx
OWASP_MASVS-*.csv/OWASP_MASVS-*.csv
OWASP_MASVS-*.json/OWASP_MASVS-*.json
OWASP_MASVS-*.xml/OWASP_MASVS-*.xml
OWASP_MASVS.pdf
OWASP_MASVS.epub
OWASP_MASVS.yaml/OWASP_MASVS.yaml
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 1
- name: markdownlint-cli
uses: nosborn/[email protected]
with:
files: './Document*'
config_file: ".github/workflows/config/.markdownlint.json"
config_file: ".markdownlint.jsonc"
ignore_files: "tools, node_modules"
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: codespell
name: Spell Checker
on: [pull_request, push]
jobs:
codespell:
spell-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: codespell-project/actions-codespell@master
with:
path: ./Document
ignore_words_list: ba,compliancy,firt,ist,keypair,ligh,ser,synopsys,zuser
ignore_words_list: OWASP,MASVS,MASTG
21 changes: 21 additions & 0 deletions .github/workflows/url-checker-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: URL Checker (PR)

on:
pull_request:

jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 1
- name: link-check
uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-quiet-mode: 'yes'
use-verbose-mode: 'yes'
config-file: '.github/workflows/config/url-checker-config.json'
folder-path: '.'
check-modified-files-only: 'yes'
Original file line number Diff line number Diff line change
@@ -1,25 +1,23 @@
name: URLs Checker
name: URL Checker

on:
workflow_dispatch:
push:
branches:
- master
pull_request:
branches:
- master

jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 1
- name: link-check
uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-quiet-mode: 'yes'
use-verbose-mode: 'yes'
config-file: '.github/workflows/config/mlc_config.json'
config-file: '.github/workflows/config/url-checker-config.json'
folder-path: '.'
Loading