Deprecate OmniExtendedClient #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate OmniExtendedClient and all its methods * Create OmniTestClient to replace OmniExtendedClient in integration tests * Create OmniTestClientDelegate trait for use in tests * OmniCLIClient now extends OmniClient rather than OmniExtendedClient * Don’t use OmniCLIClient in most tests (use OmniTestClient instead) * OmniClientDelegate uses OmniClient (not OmniCLIClient) * OmniScriptingClient uses OmniClient (not OmniExtendedClient) * Fix issue with omni_senddexsell sending real number not string (note this is different from how BTC values are sent in standard Bitcoin RPCs)
|
Looks very, very good to me! |
|
Thanks, @dexX7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note this is different from how BTC values are sent in standard Bitcoin RPCs)