Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide constructor accepting hostServices #2373

Merged
merged 7 commits into from
Apr 7, 2022
+7 −1
Merged

provide constructor accepting hostServices #2373

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2074705
provide constructor accepting hostServices
stg609 Mar 22, 2022
f1b2ef3
Merge pull request #1 from stg609/stg609-provide-constructor-acceptin…
stg609 Mar 22, 2022
4dd88ed
Update OmniSharpWorkspace.cs
stg609 Mar 22, 2022
a0b282e
Merge pull request #2 from stg609/stg609-provide-constructor-acceptin…
stg609 Mar 22, 2022
3766bd0
Remove ImportingConstructor for the overloaded constructor
stg609 Mar 30, 2022
4d98f46
Merge branch 'master' into master
stg609 Mar 31, 2022
1d60040
Merge branch 'master' into master
filipw Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/OmniSharp.Roslyn/OmniSharpWorkspace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Host;
using Microsoft.CodeAnalysis.Text;
using Microsoft.Extensions.Logging;
using OmniSharp.FileSystem;
Expand Down Expand Up @@ -50,7 +51,12 @@ public bool Initialized

[ImportingConstructor]
public OmniSharpWorkspace(HostServicesAggregator aggregator, ILoggerFactory loggerFactory, IFileSystemWatcher fileSystemWatcher)
: base(aggregator.CreateHostServices(), "Custom")
: this(aggregator.CreateHostServices(), loggerFactory, fileSystemWatcher)
{
}

public OmniSharpWorkspace(HostServices hostServices, ILoggerFactory loggerFactory, IFileSystemWatcher fileSystemWatcher)
: base(hostServices, "Custom")
{
BufferManager = new BufferManager(this, loggerFactory, fileSystemWatcher);
_logger = loggerFactory.CreateLogger<OmniSharpWorkspace>();
Expand Down