Use completion API #583
Merged
Use completion API #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like dotnet restore is failing on CI builds. Does anyone know anything about that? @troydai? |
|
Looking at it |
|
NuGet references are out-of-date. I'm going to update them,. |
|
Yeah, I just cleared my NuGet caches and can reproduce locally. |
|
Sending out PR to address this: #584 You can rebase your changes onto my fix. |
…that they are no longer needed
DustinCampbell
force-pushed
the
use-completion-api
branch
from
71932d3 to
356f0d7
Compare
|
Yay! The CI builds have passed. Just need some code reviews. |
|
|
||
| public static string GetRoslynAssemblyFullName(string name) | ||
| { | ||
| return $"{name}, Version={RoslynVersion}, Culture=neutral, PublicKeyToken={RoslynPublicKeyToken}"; |
|
LGTM |
|
Awesome! @david-driscoll, when you get a chance, could you take a look? It's a pretty big change, so I want to be sure you're OK with it. |
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the existing AutoComplete end point to use the Roslyn Completion API, which allows the old keyword recommender code to be deleted. In order to properly support the Roslyn Completion API and all of its features, we'll need a new endpoint. I'll be working on that next.
cc @david-driscoll, @troydai
Note: The last commit is huge and is mostly around deleting code. If you want to review the meatier changes, take a look at the earlier commits.