fix: delete iter before returns #2785
Conversation
WalkthroughThe recent update involves adding a Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/storage/src/redis_strings.cc (1 hunks)
Additional comments not posted (1)
src/storage/src/redis_strings.cc (1)
1764-1764: LGTM! Properly delete the iterator.The addition of
delete iter;ensures that the iterator is properly deleted, preventing potential memory leaks.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/storage/src/redis_strings.cc (2 hunks)
Additional comments not posted (1)
src/storage/src/redis_strings.cc (1)
1765-1765: LGTM! Iterator deletion before returning.The
delete iter;statement ensures proper memory management by deleting the iterator before returning the variables.
| @@ -1748,6 +1748,7 @@ rocksdb::Status Redis::PKPatternMatchDel(const std::string& pattern, int32_t* re | |||
| batch.Clear(); | |||
| } else { | |||
| *ret = total_delete; | |||
| delete iter; | |||
There was a problem hiding this comment.
Ensure the iterator is deleted before returning.
The delete iter; statement should be added before the return statement at line 1751 to prevent memory leaks.
+ delete iter;
return s;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| delete iter; | |
| delete iter; | |
| return s; |
* delete iter before return --------- Co-authored-by: wangshaoyi <[email protected]>
* delete iter before return --------- Co-authored-by: wangshaoyi <[email protected]>
pkpatternmatchdel doesn't delete iter before returns which may cause the rocksdb refs a version forever until process restarts.
Summary by CodeRabbit