Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component.update View #2958

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Jan 7, 2025

Before:

image

After:

image

Issue:

In some ways the Text overwrites the input container (See Delay before TX):

image

This change is just an example for a "Quick Fix"

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Jan 7, 2025

@lukasrgr could you please have a look? My guess is that it happened since the switch to Aangular 19 ? :)

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2958      +/-   ##
=============================================
+ Coverage      57.08%   57.09%   +0.01%     
- Complexity      9728     9732       +4     
=============================================
  Files           2266     2266              
  Lines          96819    96819              
  Branches        7163     7163              
=============================================
+ Hits           55258    55265       +7     
+ Misses         39500    39492       -8     
- Partials        2061     2062       +1     

@lukasrgr lukasrgr requested a review from sfeilmeier January 7, 2025 08:12
@sfeilmeier sfeilmeier merged commit fea6ba3 into OpenEMS:develop Jan 7, 2025
2 checks passed
@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Jan 7, 2025

@sfeilmeier you saw the "Issue" which occurs right now, right? :)

@sfeilmeier
Copy link
Contributor

No, i didn't check. I assumed it's working when reviewed by both of you?! 🤔

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Jan 7, 2025

@sfeilmeier

See in the Description:

This change is just an example for a "Quick Fix"

and

Issue:

In some ways the Text overwrites the input container (See Delay before TX):

No need to rollback - but the PR is not a 100% fix for the Problem as stated above (if the Text is longer than x Characters it overwrites input fields)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants