-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 related fixes #7456
Conversation
Centos7 is not supported by GitHub Actions anymore. Node was upgraded to 20, which requires a newer glibc. |
Yeah. I noticed. Any suggestions on the best way to move forward is? |
Only workaround is to update many Linux. Otherwise it will fail mid May. |
So this effectively means manylinux2014 is dead for GHA? |
I am pretty sure, yes. If they require node 20 for security (even when downgrading actions versions) then yes, you won't be able to use actions that use nodejs anymore. Which are most of them I guess. |
Okay. I can start taking a look at putting together a separate PR for upgrading which manylinux we are using. Tomorrow. It's past my bedtime already |
Hm maybe they keep old action versions running/allowed? |
But the linked PR feels more like a desperate attempt to evade the inevitable |
Just try to update the base container in the Linux branch of the actions here. |
I feel like you should ignore the system compat check in the test, not build step |
@@ -325,6 +333,8 @@ jobs: | |||
test: | |||
needs: [build-win, build-macos, build-lnx] | |||
runs-on: ${{ matrix.os }} | |||
env: | |||
SYSTEM_VERSION_COMPAT: 0 #courtesy of https://github.com/actions/setup-python/issues/469 in lieu of an actual solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also say here that it is a workaround for mac neded for XYZ? above is kind of fine because there it specifies on which os it runs.
Co-authored-by: Timo Sachsenberg <[email protected]>
@poshul Is there any chance this could reach a version on PyPI soon? |
Description
Checklist
How can I get additional information on failed tests during CI
Click to expand
If your PR is failing you can check outIf you click in the column that lists the failed tests you will get detailed error messages.
Advanced commands (admins / reviewer only)
Click to expand
/reformat
(experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.rebuild jenkins
will retrigger Jenkins-based CI builds