add arguments to cmd_new.py to allow no input creation of commands #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crushingCodes
commented
May 19, 2023
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| click | |||
| requests | |||
| terminaltables | |||
| PyGithub==1.43.7 | |||
| PyGithub | |||
There was a problem hiding this comment.
I needed to rm the pinned version number here to avoid the following error:
error in PyGithub setup command: use_2to3 is invalid
There was a problem hiding this comment.
is it possible something is not working with your local python setup?
rahuliyer95
reviewed
May 19, 2023
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| click | |||
| requests | |||
| terminaltables | |||
| PyGithub==1.43.7 | |||
| PyGithub | |||
There was a problem hiding this comment.
is it possible something is not working with your local python setup?
Signed-off-by: Gavin <[email protected]>
crushingCodes
force-pushed
the
add-arguments-to-create
branch
from
f917430 to
1ee0952
Compare
|
Thanks for reviewing @rahuliyer95, i reverted the requirements.txt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test use the new functionality use:
keep new --cmd hello1 --desc "echo 1" --alias " "or the original command to ensure it still works like original
keep new