This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[sonatype-nexus] Improve ingress tls hosts configuration #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the current configuration is that we need to define a complete
hosts
block in the value file like for example:More, if you do not use the nexus proxy, it results with an tls block like the following:
This PR allows to define the proxy host or the direct host tls configuration in the same block.
I think that if someone need to have the proxy host and the direct host configuration, maybe the chart needs something like a new property named
additionalTls
Downside: This is a breaking change for those who were specifying the
ingress.tls.hosts
value. I did not change the version in the Chart.yaml as I did not know if it would be a6.0.0
or something else.Feel free to tell me if I miss something.