refactor(reader): extract data qc logic to new function #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chanshing
commented
Oct 22, 2024
•
chanshing
commented
- Move qc code out of _read_device and into new function qc()
- Merge calculate_wear_coverage into qc()
chanshing
force-pushed
the
refactor/quality-control
branch
from
df4dbab to
5a74fc2
Compare
- Move qc code out of _read_device and into new function qc() - Merge calculate_wear_coverage into qc()
chanshing
force-pushed
the
refactor/quality-control
branch
from
5a74fc2 to
833af71
Compare
chanshing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.