Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump prisma from v4 to v6 #316

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

eatyourgreens
Copy link
Contributor

This works for me locally: I can sign in and out, and I can list events from the database. However, I'm not sure what jumping 2 major versions might have broken.

This works for me locally: I can sign in and out, and I can list events from the database. However, I'm not sure what jumping 2 major versions might have broken.
@eatyourgreens
Copy link
Contributor Author

yarn dev works, but yarn build hangs without building the app.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Feb 10, 2025

Turning off type checks gets the build to work, at least. Something seems to have changed that causes npx tsc to hang.

With that check removed (temporarily), I can yarn build && yarn start and run the app locally. Sign in/out works, and I can list events from the database.

I think the Prisma 6 client works without any code changes, but imported types need to be updated somewhere, maybe?

@eatyourgreens
Copy link
Contributor Author

npx prisma studio works on this branch. 👍 I didn't try modifying any tables, but I can browse the database and see data.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Feb 10, 2025

I had to delete the Docker gutenberg_node_modules volume, and recreate it, in order to get a Docker dev build to use the new client. That was unexpected. Looks like the mounted volume clobbers any changes to node-modules that were made by the build.

- node-modules:/app/node_modules

Comment on lines +12 to +14
typescript: {
ignoreBuildErrors: true,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should merge to production, by the way. I added it to test whether it was the type check that breaks the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant