Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: php-cs-fixer - removing deprecations #874

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

partikus
Copy link
Contributor

1. Detected deprecations in use:
- Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "curly_braces_position", "statement_indentation" and "no_extra_blank_lines" instead.
2. Detected deprecations in use:
- Rule "curly_braces_position" is deprecated. Use "braces_position" instead.

@mnapoli
Copy link
Member

mnapoli commented Jan 10, 2024

Thanks, you're a legend! Could you rebase or merge master into this branch so that we can check the build passes?

1. Detected deprecations in use:
- Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "curly_braces_position", "statement_indentation" and "no_extra_blank_lines" instead.

2. Detected deprecations in use:
- Rule "curly_braces_position" is deprecated. Use "braces_position" instead.
@partikus partikus force-pushed the feature/php-cs-fixer-deprecations branch from 02151f7 to 27cd8b2 Compare January 10, 2024 11:16
@partikus
Copy link
Contributor Author

@mnapoli just rebased

@mnapoli
Copy link
Member

mnapoli commented Jan 10, 2024

Beautiful, thank you!

@mnapoli mnapoli merged commit 28d15cb into PHP-DI:master Jan 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants