Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] Add Geglu fused ops on XPU backend. #10038

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

stevenshen36
Copy link
Contributor

PR devices

XPU

PR types

New features

PR changes

Pass

Description

Add Geglu fused ops on XPU backend, not included compute logic.

@paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2023

Thanks for your contribution!

Copy link
Collaborator

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考 #10037 的comment

@stevenshen36 stevenshen36 force-pushed the xpu_geglu branch 3 times, most recently from 511c26f to 96684d4 Compare February 28, 2023 12:52
@stevenshen36
Copy link
Contributor Author

已修改相关问题

@stevenshen36 stevenshen36 force-pushed the xpu_geglu branch 4 times, most recently from b30aec7 to 9d08c95 Compare March 2, 2023 02:30
@stevenshen36
Copy link
Contributor Author

@zhupengyang 如果没有其他问题的话,麻烦帮我合入一下哦,多谢啦

Copy link
Collaborator

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先合入吧。还有一些问题后面的PR中再改

}

private:
void update_weight(Scope* scope,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照本repo代码的习惯规则,用首字母大写的方式 UpdateWeight

@zhupengyang zhupengyang merged commit 54476e5 into PaddlePaddle:develop Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants