[Core] Add the graph optimization of subblocks for transformer model #3947
+2,449
−1,365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hong19860320
commented
Jul 14, 2020
•
hong19860320
commented
- Fix the dims of parent idx of the arm kernel of beam_search op
- elementwise_mul supports int64_t data type with broadcasting
- Add print op and kernel for debugging
- Support throwing the exception when the internal error occurs
- Refine while and conditional_block op kernel
- Support the graph optimization on subblocks
- Pass program_desc and block_idx into the kernel of the control flow ops(while/conditional_block/subgraph), and create the RuntimeProgram online, it make it possiable to call the control flow ops recursively
- Add unit test for masked transformer model
…_t data type, add print op and kernel, add exeception test=develop
hong19860320
changed the title
hong19860320
changed the title
…into hongming/support_subblock
…into hongming/support_subblock
test=develop
hong19860320
commented
Jul 21, 2020
| LOG(FATAL) | ||
| << "Getting 'tensor_desc' is not supported by the type of var %s." | ||
| << this->Name(); | ||
| LOG(WARNING) << "Getting 'tensor_desc' is not supported by the type(" |
There was a problem hiding this comment.
while op会带有STEP_SCOPE类型的var，如果使用FATAL会导致模型加载失败，程序挂掉。
hong19860320
requested review from
ysh329,
Superjomn,
Shixiaowei02,
NHZlX,
juncaipeng and
DannyIsFunny
Superjomn
reviewed
Jul 21, 2020
| TARGET(kHost), type.precision(), DATALAYOUT(kNCHW)); | ||
| } | ||
| } | ||
|
|
||
| // Update a's kUnk fields from b's fields. | ||
| void UpdateTypeFrom(const Type*& a, const Type* b) { // NOLINT |
There was a problem hiding this comment.
const Type*&a -> const Type* a ?
POD 不需要引用
There was a problem hiding this comment.
需要修改a的值的，等价于const Type** a
There was a problem hiding this comment.
为了防止歧义，已修改为const Type** a
| const char kBackward[] = "BACKWARD"; | ||
| const char kBoth[] = "BOTH"; | ||
|
|
||
| class TensorFormatter { |
There was a problem hiding this comment.
| if [[ $WITH_EXCEPTION == "ON" && $ARCH == "armv7" && $TOOLCHAIN != "clang" ]]; then | ||
| set +x | ||
| echo | ||
| echo -e "Error: only clang provide C++ exception handling support for 32-bit ARM." |
There was a problem hiding this comment.
是否需要修改文档？
只有在armv7需要支持exception的时候才要求用clang，而支持exception是一个新特性，可以在发版的时候修改文档
Shixiaowei02
previously approved these changes
Jul 21, 2020
…into hongming/support_subblock test=develop
Shixiaowei02
approved these changes
Jul 22, 2020
hong19860320
added a commit
to hong19860320/Paddle-Lite
that referenced
this pull request
Jul 22, 2020
…former model (PaddlePaddle#3947) test=develop * [Core][ARM] Fix beam_search, eltwise_mul supports broadcast and int64_t data type, add print op and kernel, add exeception test=develop * Fix the dims of parent idx of the arm kernel of beam_search op * elementwise_mul supports int64_t data type with broadcasting * Add print op and kernel for debugging * Support throwing the exception when the internal error occurs * Refine while and conditional_block op kernel * Support the graph optimization on subblocks * Pass program_desc and block_idx into the kernel of the control flow ops(while/conditional_block/subgraph), and create the RuntimeProgram online, it make it possiable to call the control flow ops recursively *Add unit test for masked transformer model
hong19860320
added a commit
that referenced
this pull request
Jul 23, 2020
…former model (#3947) (#3979) * [Cherry-pick][Core] Add the graph optimization of subblocks for transformer model (#3947) test=develop * [Core][ARM] Fix beam_search, eltwise_mul supports broadcast and int64_t data type, add print op and kernel, add exeception test=develop * Fix the dims of parent idx of the arm kernel of beam_search op * elementwise_mul supports int64_t data type with broadcasting * Add print op and kernel for debugging * Support throwing the exception when the internal error occurs * Refine while and conditional_block op kernel * Support the graph optimization on subblocks * Pass program_desc and block_idx into the kernel of the control flow ops(while/conditional_block/subgraph), and create the RuntimeProgram online, it make it possiable to call the control flow ops recursively *Add unit test for masked transformer model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.