[BugFix][KERNEL][OPENCL] Fix conv3x3 group. test=develop #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ysh329
added a commit
to ysh329/Paddle-Lite-1
that referenced
this pull request
Sep 2, 2020
…e#4236) * fix conv3x3 group. test=develop * remove useless. test=develop * optimize 3x3 group
ysh329
added a commit
that referenced
this pull request
Sep 2, 2020
* [BugFix][KERNEL][OPENCL] Fix conv3x3 group. test=develop (#4236) * cherry-pick Fix conv3x3 group * cherry-pick 394c283(fix concat etc.). test=develop * cherry-pick transpose, transpose2(732bb91). test=develop Co-authored-by: dustybluebird <[email protected]>
juncaipeng
pushed a commit
to juncaipeng/Paddle-Lite
that referenced
this pull request
Oct 27, 2020
…e#4236) * fix conv3x3 group. test=develop * remove useless. test=develop * optimize 3x3 group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
状态：等待review
主要内容
简单分析
cl kernel里有一个half4 input[9]; 这么个变量，在大部分手机上都没问题，就那两个手机（oppo骁龙625和三星某手机）分别出现结果写入到这个input[9]的某个分量里如input[3].x写入失败（oppo骁龙625），和重启（三星）。
经 @zhaoyang-star 的建议，尝试把这个half4 input[9]，改为half4 input0，input1....定义9个，就不会出现这个上面的问题了。我猜想是不是这种half4 input[9]定义的方式超出了手机gpu的设置，导致的写入失败。当然，感觉这个问题的内存本质，我感觉还可以再深入探究下。