Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wandb Sweep Support #454

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Added Wandb Sweep Support #454

merged 6 commits into from
Mar 15, 2024

Conversation

Pale-Blue-Dot-97
Copy link
Owner

Small PR to close #309 by adding support for wandb.sweep. Also fixes a RecurssionError bug from PairedNonGeoDataset that cropped up in wandb.sweep usage.

Note

Fixing the RecurssionError bug required the removal of the __new__ and __getattr__ methods from PairedNonGeoDataset. This has resulted in the loss of some flexibility such as being able to create a PairedConcatDataset using the constructor of PairedNonGeoDataset if the supplied dataset is already a ConcatDataset.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added bug Something isn't working enhancement New feature or request python Pull requests that update Python code labels Mar 13, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.64%. Comparing base (a5609e1) to head (916356c).
Report is 30 commits behind head on beta.

Files Patch % Lines
minerva/datasets/factory.py 0.00% 1 Missing ⚠️
minerva/datasets/paired.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #454      +/-   ##
==========================================
- Coverage   97.78%   97.64%   -0.14%     
==========================================
  Files          39       39              
  Lines        4147     4166      +19     
==========================================
+ Hits         4055     4068      +13     
- Misses         92       98       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 merged commit 23233e5 into beta Mar 15, 2024
11 of 14 checks passed
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 deleted the 309-wandbsweep-dev branch March 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant