Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra Integration and Downstream Support #505

Merged
merged 397 commits into from
Jul 10, 2024
Merged

Conversation

Pale-Blue-Dot-97
Copy link
Owner

Major PR that adds hydra integration and much better support for downstream uses.

Major Updates

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added bug Something isn't working enhancement New feature or request generalise Code needs generalising dependencies Pull requests that update a dependency file testing New tests needed restructure Restructure package type hinting Relates to missing/new or broken/fixed type-hints python Pull requests that update Python code github_actions Pull requests that update GitHub Actions code markdown Updates to Markdown notebooks Updates to Juypter Notebooks labels Jul 10, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 77.03488% with 316 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (916356c) to head (55980b7).
Report is 161 commits behind head on beta.

Files Patch % Lines
minerva/datasets/ssl4eos12.py 26.50% 147 Missing ⚠️
minerva/datasets/paired.py 80.15% 25 Missing ⚠️
minerva/datasets/factory.py 89.77% 18 Missing ⚠️
minerva/modelio.py 60.86% 18 Missing ⚠️
minerva/transforms.py 83.83% 16 Missing ⚠️
minerva/trainer.py 86.36% 15 Missing ⚠️
minerva/utils/visutils.py 85.22% 13 Missing ⚠️
minerva/datasets/utils.py 64.70% 12 Missing ⚠️
minerva/logger/steplog.py 80.76% 10 Missing ⚠️
minerva/utils/runner.py 85.45% 8 Missing ⚠️
... and 10 more

❗ There is a different number of reports uploaded between BASE (916356c) and HEAD (55980b7). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (916356c) HEAD (55980b7)
8 5
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #505      +/-   ##
==========================================
- Coverage   97.64%   91.95%   -5.69%     
==========================================
  Files          39       42       +3     
  Lines        4166     4663     +497     
==========================================
+ Hits         4068     4288     +220     
- Misses         98      375     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 merged commit 72499e6 into beta Jul 10, 2024
9 of 13 checks passed
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 deleted the 458-downstream-tasks branch October 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request generalise Code needs generalising github_actions Pull requests that update GitHub Actions code markdown Updates to Markdown notebooks Updates to Juypter Notebooks python Pull requests that update Python code restructure Restructure package testing New tests needed type hinting Relates to missing/new or broken/fixed type-hints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant