Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the brpd line of sight check #28249

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

Toastical
Copy link
Contributor

What Does This PR Do

changes viewers to hearers cause viewers includes every mob that can see the turf, even if they're behind a wall with mesons. Thus, the line of sight check now uses hearers! At least until the proc isn't changed.

Why It's Good For The Game

it didnt work properly before. It works properly now.

Testing

Tried BRPD-wrenching behind solid walls and airlocks with both mesons and cling augmented sight.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: BRPD Line of Sight check is properly functional again
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 4, 2025
@silverplatedelta silverplatedelta added Tweak This PR tweaks something ingame Fix This PR will fix an issue in the game and removed Tweak This PR tweaks something ingame labels Feb 12, 2025
Copy link
Contributor

@BiancaWilkson BiancaWilkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for a one-line approval.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 22, 2025
@lewcc lewcc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into ParadiseSS13:master with commit 72bf019 Feb 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants