Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes shuttles lazy load #28315

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Feb 9, 2025

What Does This PR Do

Makes shuttles use lazyloading. Moves them off the centcomm z-level. Heavily based on TG shuttles.

Probably waiting on #27873 to be merged first.

PR desc WIP.

Why It's Good For The Game

It clears up a lot of space on centcomm and takes advantage of our new lazy-loading system.

Images of changes

will come later

Testing

A lot of flying shuttles. Did it with parallax and without parallax, realized that non-parallax is broken on master.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map labels Feb 9, 2025
@Contrabang Contrabang marked this pull request as ready for review February 10, 2025 17:32
@Contrabang Contrabang added the Refactor This PR will clean up the code but have the same ingame outcome label Feb 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Active This PR is currently testmerged on production and removed Testmerge Active This PR is currently testmerged on production labels Feb 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Feb 11, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 11, 2025
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@AffectedArc07 AffectedArc07 added this pull request to the merge queue Feb 11, 2025
@Burzah Burzah removed this pull request from the merge queue due to a manual request Feb 11, 2025
@Qwertytoforty
Copy link
Contributor

image

@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Feb 12, 2025
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lance shuttle is apparently fine

@Burzah prepare for AFD

@AffectedArc07 AffectedArc07 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into ParadiseSS13:master with commit 781c6e9 Feb 26, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Map Edit This PR will modify a map Refactor This PR will clean up the code but have the same ingame outcome Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants