-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes shuttles lazy load #28315
Merged
AffectedArc07
merged 9 commits into
ParadiseSS13:master
from
Contrabang:shuttle-reservation
Feb 26, 2025
Merged
Makes shuttles lazy load #28315
AffectedArc07
merged 9 commits into
ParadiseSS13:master
from
Contrabang:shuttle-reservation
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burzah
approved these changes
Feb 11, 2025
AffectedArc07
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
AffectedArc07
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lance shuttle is apparently fine
@Burzah prepare for AFD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting merge
This PR is ready for merge
Map Edit
This PR will modify a map
Refactor
This PR will clean up the code but have the same ingame outcome
Testmerge Requested
This PR has a pending testmerge request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Makes shuttles use lazyloading. Moves them off the centcomm z-level. Heavily based on TG shuttles.
Probably waiting on #27873 to be merged first.
PR desc WIP.
Why It's Good For The Game
It clears up a lot of space on centcomm and takes advantage of our new lazy-loading system.
Images of changes
will come later
Testing
A lot of flying shuttles. Did it with parallax and without parallax, realized that non-parallax is broken on master.
Declaration
Changelog
NPFC